Time parameter in xAOD::TrackParticle

Up until now, the output of HGTD reconstruction has been a collection of xAOD::TrackParticle decorations conveying the HGTD timing information (with track and vertex times being derived from them post-reco). This MR is a first step towards a more integrated track time in the xAOD EDM.

The topic was discussed in a core software meeting, where a preliminary strategy was proposed to add the time as dynamic for now. This should make it relatively transparent for Run 3 code, but usable for upgrade code (in which case the time will still need to be set on every track).

/cc @akraszna @npetters @tadej @tstreble @ncalace @pagessin @lgagnon @aleopold

assigned to @dshope

Hi all,

so far I've just pushed some small changes just to get the discussion started. I wasn't sure whether or not this change would warrant a new version of the interface class (I see that for updates so far, the same version is reused). Any thoughts or suggestions are welcome!

added 1 commit

• c9fdce7e - Reduce code duplication

Compare with previous version

Hi,

but usable for upgrade code (in which case the time will still need to be set on every track).

That was the importand bit in the discussion if I recall assuming there is one collection (as we do not want to add info only in some track particles of the collection). I think what you do is OK.

Since you are using accessor do you have already an idea how this is to be used. In short should we have already a modified TrackParticleCreator what not to see how the interface fits in?

warrant a new version of the interface class

No , the moral of many discussions is that interface class versioning is something we would do very rarely if at all. @akraszna can give more details ...

added 1 commit

• 7ce9612b - Add static keywords and remove TODO comment

Compare with previous version

added 1 commit

• bb62018a - Add hasValidTime to track summary and separate method for retrieval

Compare with previous version

Un-drafting now since from the HGTD side, we propose to add the rest of the TODO items in future MRs. As a summary of the discussion above, the list of remaining developments is as follows:

• Interface HGTD extension with TrackParticleCreatorTool
• Encode timing "quality cuts" into track summary
• Add time uncertainty
• Consider flexibility for different time of flight corrections

marked this merge request as ready

This merge request affects 1 package:

• Event/xAOD/xAODTracking

This merge request affects 4 files:

• Event/xAOD/xAODTracking/Root/TrackParticle_v1.cxx
• Event/xAOD/xAODTracking/Root/TrackSummaryAccessors_v1.cxx
• Event/xAOD/xAODTracking/xAODTracking/TrackingPrimitives.h
• Event/xAOD/xAODTracking/xAODTracking/versions/TrackParticle_v1.h

Adding @amorley ,@akraszna as watchers

added EDM analysis-review-required master review-pending-level-1 labels

added HGTD Tracking labels

CI Result SUCCESS (hash bb62018a)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 58360]

added review-user-action-required label and removed review-pending-level-1 label

relabeling while discussions are ongoing...

resolved all threads

removed review-user-action-required label

added review-pending-level-1 label

let me ping @akraszna in case he spots something

For me this list of todo

Interface HGTD extension with TrackParticleCreatorTool
Encode timing "quality cuts" into track summary
Add time uncertainty
Consider flexibility for different time of flight corrections

makes sense

added review-approved label and removed review-pending-level-1 label

added analysis-review-approved label and removed analysis-review-required label

resolved all threads

merged

mentioned in commit ea589e35

added sweep:ignore label