23.0-cleanup-PixelConditionsAlgorithms

Factor out database string parser for the DeadMap conditions in PixelDeadMapCondAlg.cxx, and introduce unit test. Facilitates optimisation and further debugging. Motivated by ATLASRECTS-6600 and !46968 (closed)

assigned to @sroe

This merge request affects 1 package:

• InnerDetector/InDetConditions/PixelConditionsAlgorithms

This merge request affects 6 files:

• InnerDetector/InDetConditions/PixelConditionsAlgorithms/CMakeLists.txt
• InnerDetector/InDetConditions/PixelConditionsAlgorithms/src/PixelDeadMapCondAlg.cxx
• InnerDetector/InDetConditions/PixelConditionsAlgorithms/src/StringUtilities.cxx
• InnerDetector/InDetConditions/PixelConditionsAlgorithms/src/StringUtilities.h
• InnerDetector/InDetConditions/PixelConditionsAlgorithms/test/DeadMapTestString.h
• InnerDetector/InDetConditions/PixelConditionsAlgorithms/test/StringUtilities_test.cxx

Adding @goetz ,@stsuno ,@lshan ,@battagl ,@sroe as watchers

added InnerDetector master review-pending-level-1 labels

added Run2-DataReco-output-changed Run2-MCOverlay-output-changed Run2-MCReco-output-changed Run3-DataReco-output-changed Run3-MCOverlay-output-changed Run3-MCReco-output-changed labels

CI Result FAILURE (hash 5e9fa2cc)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 57563]

clearly I got that wrong! will address.

marked this merge request as draft

added 1 commit

• 26cc3ff9 - correct silly mistake

Compare with previous version

Jenkins please retry a build

This merge request affects 1 package:

• InnerDetector/InDetConditions/PixelConditionsAlgorithms

This merge request affects 6 files:

• InnerDetector/InDetConditions/PixelConditionsAlgorithms/CMakeLists.txt
• InnerDetector/InDetConditions/PixelConditionsAlgorithms/src/PixelDeadMapCondAlg.cxx
• InnerDetector/InDetConditions/PixelConditionsAlgorithms/src/StringUtilities.cxx
• InnerDetector/InDetConditions/PixelConditionsAlgorithms/src/StringUtilities.h
• InnerDetector/InDetConditions/PixelConditionsAlgorithms/test/DeadMapTestString.h
• InnerDetector/InDetConditions/PixelConditionsAlgorithms/test/StringUtilities_test.cxx

Adding @goetz ,@stsuno ,@lshan ,@battagl ,@sroe as watchers

removed review-pending-level-1 label

added 1 commit

• f59cb71f - correct silly mistake 2

Compare with previous version

marked this merge request as ready

This merge request affects 1 package:

• InnerDetector/InDetConditions/PixelConditionsAlgorithms

This merge request affects 6 files:

• InnerDetector/InDetConditions/PixelConditionsAlgorithms/CMakeLists.txt
• InnerDetector/InDetConditions/PixelConditionsAlgorithms/src/PixelDeadMapCondAlg.cxx
• InnerDetector/InDetConditions/PixelConditionsAlgorithms/src/StringUtilities.cxx
• InnerDetector/InDetConditions/PixelConditionsAlgorithms/src/StringUtilities.h
• InnerDetector/InDetConditions/PixelConditionsAlgorithms/test/DeadMapTestString.h
• InnerDetector/InDetConditions/PixelConditionsAlgorithms/test/StringUtilities_test.cxx

Adding @goetz ,@stsuno ,@lshan ,@battagl ,@sroe as watchers

added review-pending-level-1 label

CI Result FAILURE (hash 26cc3ff9)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 57570]

this attempt prior to last fix; still awaiting final pipeline result.

CI Result SUCCESS (hash f59cb71f)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 57571]

removed Run3-MCOverlay-output-changed label

removed Run3-DataReco-output-changed label

removed Run2-MCReco-output-changed label

removed Run2-DataReco-output-changed label

removed Run2-MCOverlay-output-changed label

removed Run3-MCReco-output-changed label

shouldn't those "changes output" labels be automatically removed when the code is fixed?

Looks good to me, approving - L1

removed review-pending-level-1 label

added review-approved label

resolved all threads

merged

mentioned in commit fcae14c4

added sweep:ignore label

mentioned in merge request !56080 (merged)