LArG4Code: do not delete ILArCalculatorSvc
LArG4SimpleSD
and LArG4CalibSD
are deleting the ILArCalculatorSvc
on
their destruction claiming they are "owning" it. That is certainly
wrong as services are not owned by an individual component. Likely
didn't cause problems so far because the G4 RunManager who ultimately
triggers this destructor is not being cleaned up properly either.
Merge request reports
Activity
assigned to @fwinkl
This merge request affects 1 package:
- LArCalorimeter/LArG4/LArG4Code
This merge request affects 2 files:
- LArCalorimeter/LArG4/LArG4Code/src/LArG4CalibSD.cc
- LArCalorimeter/LArG4/LArG4Code/src/LArG4SimpleSD.cc
Adding @pavol as watcher
added JetEtmiss LAr Simulation master review-pending-level-1 labels
mentioned in merge request !56205 (merged)
CI Result SUCCESS (hash c5dbc384)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 57995]added review-approved label and removed review-pending-level-1 label
mentioned in commit 75bc6e0d
added sweep:ignore label