Skip to content
Snippets Groups Projects

LArG4Code: do not delete ILArCalculatorSvc

Merged Frank Winklmeier requested to merge fwinkl/athena:fwinkl_20220825T180035 into master

LArG4SimpleSD and LArG4CalibSD are deleting the ILArCalculatorSvc on their destruction claiming they are "owning" it. That is certainly wrong as services are not owned by an individual component. Likely didn't cause problems so far because the G4 RunManager who ultimately triggers this destructor is not being cleaned up properly either.

Merge request reports

Pipeline #4411394 passed

Pipeline passed for c5dbc384 on fwinkl:fwinkl_20220825T180035

Approval is optional

Merged by Johannes ElmsheuserJohannes Elmsheuser 2 years ago (Aug 26, 2022 11:56am UTC)

Merge details

  • Changes merged into master with 75bc6e0d.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading