LArStraightAbsorbers+Electrodes: remove lazy initialization of members

Similar to (!56268 (merged)) this makes several improvements to LArStraightAbsorbers and LArStraightElectodes:

• Separate setters and getters for the internal values to avoid "filled" flag and inline the getters.
• Explicitly pass PhysicalVolumeAccessor to SlantAbs/SlantEle and make it private.
• Use static const initialization to avoid use of std::once.
• Merge calculation of x and y values to avoid code duplication (should also be faster).
• Use sincos.

Relates to ATLASRECTS-7235.

assigned to @fwinkl

This merge request affects 1 package:

• LArCalorimeter/LArG4/LArG4Barrel

This merge request affects 3 files:

• LArCalorimeter/LArG4/LArG4Barrel/src/LArBarrelGeometry.h
• LArCalorimeter/LArG4/LArG4Barrel/src/LArStraightAbsorbers.cxx
• LArCalorimeter/LArG4/LArG4Barrel/src/LArStraightAbsorbers.h

Adding @pavol as watcher

added JetEtmiss LAr Simulation master review-pending-level-1 labels

marked this merge request as draft

added 1 commit

• 037ccd01 - LArStraightElectrodes: remove lazy initialization of members

Compare with previous version

changed title from Draft: LArStraightAbsorbers: remove lazy initialization of members to Draft: LArStraightAbsorbers+Electrodes: remove lazy initialization of members

changed the description

added 1 commit

• b139ad7a - LArStraightElectrodes: remove lazy initialization of members

Compare with previous version

marked this merge request as ready

This merge request affects 1 package:

• LArCalorimeter/LArG4/LArG4Barrel

This merge request affects 5 files:

• LArCalorimeter/LArG4/LArG4Barrel/src/LArBarrelGeometry.h
• LArCalorimeter/LArG4/LArG4Barrel/src/LArStraightAbsorbers.cxx
• LArCalorimeter/LArG4/LArG4Barrel/src/LArStraightAbsorbers.h
• LArCalorimeter/LArG4/LArG4Barrel/src/LArStraightElectrodes.cxx
• LArCalorimeter/LArG4/LArG4Barrel/src/LArStraightElectrodes.h

Adding @pavol as watcher

CI Result SUCCESS (hash b139ad7a)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 1
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 58076]

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• 762dec5f - LArStraightElectrodes: remove lazy initialization of members

Compare with previous version

This merge request affects 1 package:

• LArCalorimeter/LArG4/LArG4Barrel

This merge request affects 5 files:

• LArCalorimeter/LArG4/LArG4Barrel/src/LArBarrelGeometry.h
• LArCalorimeter/LArG4/LArG4Barrel/src/LArStraightAbsorbers.cxx
• LArCalorimeter/LArG4/LArG4Barrel/src/LArStraightAbsorbers.h
• LArCalorimeter/LArG4/LArG4Barrel/src/LArStraightElectrodes.cxx
• LArCalorimeter/LArG4/LArG4Barrel/src/LArStraightElectrodes.h

Adding @pavol as watcher

added review-pending-level-1 label and removed review-user-action-required label

added 189 commits

• 762dec5f...46d003b1 - 187 commits from branch atlas:master
• e6cd115e - LArStraightAbsorbers: remove lazy initialization of members
• 13dc2f24 - LArStraightElectrodes: remove lazy initialization of members

Compare with previous version

This merge request affects 1 package:

• LArCalorimeter/LArG4/LArG4Barrel

This merge request affects 5 files:

• LArCalorimeter/LArG4/LArG4Barrel/src/LArBarrelGeometry.h
• LArCalorimeter/LArG4/LArG4Barrel/src/LArStraightAbsorbers.cxx
• LArCalorimeter/LArG4/LArG4Barrel/src/LArStraightAbsorbers.h
• LArCalorimeter/LArG4/LArG4Barrel/src/LArStraightElectrodes.cxx
• LArCalorimeter/LArG4/LArG4Barrel/src/LArStraightElectrodes.h

Adding @pavol as watcher

CI Result SUCCESS (hash 762dec5f)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 58148]

CI Result SUCCESS (hash 13dc2f24)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 58176]

Looks good, approving - L1

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit ac8216a2

mentioned in merge request !56356 (merged)

added sweep:ignore label