Added codes to allow modifying Xi2max value in preinclude

Modified TrigFastTrackFinder_Config.py and ConfigSettingBase.py to allow change of Xi2max value in preinclude file, similar to the way of changing pTmin.

assigned to @yuwen

This merge request affects 2 packages:

• Trigger/TrigAlgorithms/TrigFastTrackFinder
• Trigger/TrigTools/TrigInDetConfig

Affected files list will not be printed in this case

Adding @sutt ,@mvozak ,@nagano as watchers

added Trigger TriggerID master review-pending-level-1 labels

added 1 commit

• 35ea4ade - Update ConfigSettingsBase.py to have self._Xi2max=None

Compare with previous version

This merge request affects 2 packages:

• Trigger/TrigAlgorithms/TrigFastTrackFinder
• Trigger/TrigTools/TrigInDetConfig

Affected files list will not be printed in this case

Adding @sutt ,@mvozak ,@nagano as watchers

The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)FullSim.*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

CI Result FAILURE (hash 35ea4ade)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 58135]

The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)FullSim.*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

CI Result FAILURE (hash 49294d82)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 58134]

There's a CI test CITest_TriggerDataCAConfig-test that's giving an error: KeyError: 'Duplicated flag name: Xi2max', could you please investigate?
Albert (L1)

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• 35a2a018 - Update TrigFastTrackFinder_Config.py to have Xi2maxMultiTracks = Xi2max

Compare with previous version

This merge request affects 2 packages:

• Trigger/TrigAlgorithms/TrigFastTrackFinder
• Trigger/TrigTools/TrigInDetConfig

Affected files list will not be printed in this case

Adding @sutt ,@mvozak ,@nagano as watchers

added review-pending-level-1 label and removed review-user-action-required label

The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)FullSim.*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

CI Result FAILURE (hash 35a2a018)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 58153]

There are still CI problems with this MR:

Traceback (most recent call last):
  File "/build2/ci-builds/master/Athena/build/Athena/x86_64-centos7-gcc11-opt/python/TrigInDetConfig/TrigTrackingPassFlags.py", line 79, in setUp
    flags.Trigger.InDetTracking.Muon
  File "/build2/ci-builds/master/Athena/build/Athena/x86_64-centos7-gcc11-opt/python/AthenaConfiguration/AthConfigFlags.py", line 116, in __getattr__
    self._flags._loadDynaFlags( merged )
  File "/build2/ci-builds/master/Athena/build/Athena/x86_64-centos7-gcc11-opt/python/AthenaConfiguration/AthConfigFlags.py", line 244, in _loadDynaFlags
    __load_impl( '.'.join(pathfrags[:maxf]) )
  File "/build2/ci-builds/master/Athena/build/Athena/x86_64-centos7-gcc11-opt/python/AthenaConfiguration/AthConfigFlags.py", line 236, in __load_impl
    self.join( generator(), flagBaseName if prefix else "" )
  File "/build2/ci-builds/master/Athena/build/Athena/x86_64-centos7-gcc11-opt/python/TrigInDetConfig/TrigTrackingPassFlags.py", line 35, in __muonFlags
    return __flagsFromConfigSettings(_ConfigSettings_muon())
  File "/build2/ci-builds/master/Athena/build/Athena/x86_64-centos7-gcc11-opt/python/TrigInDetConfig/TrigTrackingPassFlags.py", line 17, in __flagsFromConfigSettings
    flags.addFlag(setting, lambda pf: None)
  File "/build2/ci-builds/master/Athena/build/Athena/x86_64-centos7-gcc11-opt/python/AthenaConfiguration/AthConfigFlags.py", line 197, in addFlag
    raise KeyError("Duplicated flag name: {}".format( name ))
KeyError: 'Duplicated flag name: Xi2max'

Could you have another look?

Cheers, Martin (L1)

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• 21bbf1c6 - Update TrigTrackingPassFlags.py

Compare with previous version

This merge request affects 2 packages:

• Trigger/TrigAlgorithms/TrigFastTrackFinder
• Trigger/TrigTools/TrigInDetConfig

Affected files list will not be printed in this case

Adding @sutt ,@amorley ,@nagano ,@mvozak as watchers