LArG4EC: thread-checker fixes

• Since EnergyCalculator is a service and should only exist once, replace all non-const statics with instance variables.
• const-initialize volumeMap in CalibrationCalculator

Enable thread-checker.

This merge request affects 1 package:

• LArCalorimeter/LArG4/LArG4EC

This merge request affects 6 files:

• LArCalorimeter/LArG4/LArG4EC/LArG4EC/ATLAS_CHECK_THREAD_SAFETY
• LArCalorimeter/LArG4/LArG4EC/src/BarretteEnergyCalculator.cc
• LArCalorimeter/LArG4/LArG4EC/src/CryostatCalibrationCalculator.cc
• LArCalorimeter/LArG4/LArG4EC/src/EnergyCalculator.cc
• LArCalorimeter/LArG4/LArG4EC/src/EnergyCalculator.h
• LArCalorimeter/LArG4/LArG4EC/src/LArEMECChargeCollection.cc

Adding @pavol as watcher

added JetEtmiss LAr Simulation master review-pending-level-1 labels

CI Result SUCCESS (hash d7da5ada)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 58415]

Approved
Albert (L1)

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 2632705b

added sweep:ignore label