Skip to content

Fix flag propagation from RecExCommon to Trigger reco config

Fix the ConfigFlags propagation to old-JO Trigger Reco configuration by dropping the Configured class inheritance in config "getters" and turning them into simple functions which take flags as argument.

This is a follow-up from !55891 (closed) and implements @fwinkl's suggestion of dropping the Configured base class, as well as skips the problematic change from objKeyStore to addToESD/AOD which blocked the previous MR.

To ease the client migration, the functions have a fallback feature of default argument value flags=None in which case they import the global ConfigFlags object. This MR migrates only one (and the main) client, RecExCommon_topOptions.py. Other clients will be adapted in a separate MR.

For reviewers: most changes in this MR are in indentation or search-and-replace ConfigFlags->flags. It might be the easiest to review in side-by-side view, possibly with the option to hide whitespace changes.

Merge request reports

Loading