Add uncalibrated measurement link to calibrated one
Merge request reports
Activity
added EDM analysis-review-required master review-pending-level-1 labels
Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals 
cmake make 
tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Resolved by Tomasz BoldSo this is an error:
/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/xAOD/xAODTracking/test/xAODTracking_MultiTrajectoryBackends_test.cxx:135:70: error: cannot convert 'const ElementLink<DataVector<xAOD::UncalibratedMeasurement_v1> >' to 'const UncalibratedMeasurement*' {aka 'const xAOD::UncalibratedMeasurement_v1*'} in initialization 135 | const xAOD::UncalibratedMeasurement * u = m->uncalibratedLink();Unless there is (hopefully) some obvious mistake (which I can't see) we may be having issue with EL and polymorphism?
- Last reply by Tomasz Bold
added review-user-action-required label and removed review-pending-level-1 label
added review-pending-level-1 label and removed review-user-action-required label
-
Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Resolved by Tomasz BoldError is
/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/xAOD/xAODTracking/test/xAODTracking_MultiTrajectoryBackends_test.cxx: In member function 'void {anonymous}::TrackMeasurementsLinksToUncalibratedMeasurement::test_method()': /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/xAOD/xAODTracking/test/xAODTracking_MultiTrajectoryBackends_test.cxx:118:97: error: no matching function for call to 'ElementLink<DataVector<xAOD::StripCluster_v1> >::ElementLink(xAOD::StripCluster_v1*&)' 118 | m->setUncalibratedMeasurementLink(ElementLink<xAOD::StripClusterContainer>(stripCluster1)); // skipping intentionally 1st element- Last reply by Tomasz Bold
added 1 commit
- 283708ba - Added inheritance declarations between Pixel/Strip Cluster &...
removed review-pending-level-1 label
added review-pending-level-1 label
- Resolved by Tomasz Bold
Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
- Last reply by Attila Krasznahorkay
added 1 commit
- b4e718b5 - Shorted names in new tracking EDM, fixed inheritance declarations for...
added JetEtmiss label
-
Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
- Resolved by Tomasz Bold
Hi @tbold, the compilation issue is the following:
In file included from /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/xAOD/xAODTracking/Root/TrackMeasurementsAuxContainer_v1.cxx:4: /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/xAOD/xAODTracking/xAODTracking/versions/TrackMeasurementsAuxContainer_v1.h:8:10: fatal error: xAODMeasurementBase/UncalibratedMeasurementContainer.h: No such file or directory 8 | #include "xAODMeasurementBase/UncalibratedMeasurementContainer.h" | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ - Last reply by Tomasz Bold
Changing label to review-user-action-required until the discussions are resolved. Clara (L1)
added review-user-action-required label and removed review-pending-level-1 label
added 1 commit
- 1e17f7cd - Added MeasurementBase in other projects, simpler test name
-
This merge request affects 5 packages:
- Event/xAOD/xAODInDetMeasurement
- Event/xAOD/xAODMeasurementBase
- Event/xAOD/xAODTracking
- Projects/AnalysisBase
- Projects/AthGeneration
Affected files list will not be printed in this case
Adding @amorley ,@akraszna ,@stsuno ,@krumnack ,@lshan ,@battagl ,@rbianchi as watchers
added Build review-pending-level-1 labels and removed review-user-action-required label
-
Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
-
Unfortunately there are further "unsatisfied" dependencies in the AnalysisBase project. Trying to fixe them. But this looks like a snowball type issue. I guess we need to refactor UncalibratedMeasurement. I have an idea that instead of the hash that api could just use
unsigned int? In the end it is all it is.We have type agnostic EL in trigger: https://gitlab.cern.ch/atlas/athena/-/blob/master/Event/xAOD/xAODTrigger/xAODTrigger/versions/TrigComposite_v1.h#L106 could use this approach to decouple xAODTracking from xAODMeasurementBase.
Edited by Tomasz Bold 
Moving this back to review-user-action-required until the issues are resolved.
Jason (L1)
added review-user-action-required label and removed review-pending-level-1 label
mentioned in merge request !57056 (merged)
added 589 commits
-
1e17f7cd...de9625d6 - 588 commits from branch
atlas:master - 4f7019d3 - Resolved conflicts
-
1e17f7cd...de9625d6 - 588 commits from branch
added review-pending-level-1 label and removed review-user-action-required label
-
Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
removed analysis-review-required label
added analysis-review-expert label
removed analysis-review-expert label
added analysis-review-approved label
removed review-pending-level-1 label
added review-approved label
mentioned in commit beeee08b
added sweep:ignore label
