For HepMC3, GenParticle barcodes can only be set once they are associated with a GenEvent

The changes in this merge request a a fix for simulation in HepMC3-based builds. Most changes are protected behind preprocessor checks, so would not be seen in HepMC2-based builds.

In order to be able to do this consistently with the HepMC2 implementation, it was necessary to extend the ITruthIncident interface to be able to retrieve a child particle barcode set by the simulator.

Tagging @averbyts, @ewelina, @mgignac, @jkretz, @dhirsch, @tlari, @mbandier for the other changes.
Tagging @lmijovic for the ITruthIncident changes.

added 1 commit

• 296802de - For HepMC3, GenParticle barcodes can only be set once they are associated with a GenEvent

Compare with previous version

added 356 commits

• 296802de...492c81f8 - 353 commits from branch atlas:master
• 37043c7f - For HepMC3, GenParticle barcodes can only be set once they are associated with a GenEvent
• 49e1e754 - Force particle order in InputConverter
• b7686cfe - Workaround feature in HepMC3::GenVertex::position()

Compare with previous version

added 5 commits

• 384ce085 - Workaround feature in HepMC3::GenVertex::position()
• d7142170 - Protection for ZeroLifetimePositioner in the case that beam spot smearing has been skipped
• a0807076 - HepMC3: Fix quasi-stable particle vertex position adjusting in the case that...
• ccf8eb9c - For HepMC3, GenParticle barcodes can only be set once they are associated with a GenEvent
• 95f5f3d7 - Force particle order in InputConverter

Compare with previous version

added 112 commits

• 95f5f3d7...93e1129d - 110 commits from branch atlas:master
• 08c6f3c8 - For HepMC3, GenParticle barcodes can only be set once they are associated with a GenEvent
• fc04b888 - Force particle order in InputConverter

Compare with previous version

added 2 commits

• 0fb0f83d - For HepMC3, GenParticle barcodes can only be set once they are associated with a GenEvent
• ee7f7248 - Force particle order in InputConverter

Compare with previous version

changed the description

added alsoTargeting:22.0 label

changed the description

added bugfix label

marked this merge request as ready

Build area was cleaned as per request posted in the DB. The full software build will be performed

This merge request affects 3 packages:

• Simulation/ISF/ISF_Core/ISF_Event
• Simulation/ISF/ISF_Core/ISF_Services
• Simulation/ISF/ISF_Geant4/ISF_Geant4Event

Affected files list will not be printed in this case

Adding @jchapman as watcher

added Simulation master review-pending-level-1 labels

CI Result SUCCESS (hash 0fb0f83d)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 59430]

Hi, looks good, thus approving. L1

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 2085f2e1

added sweep:done label

picked the changes into the branch cherry-pick-2085f2e14e5-22.0 with commit b5597b0d

mentioned in commit b5597b0d

Sweep summary
successful:

• 22.0

(see https://aiatlas154.cern.ch/jenkins/job/auto_git_sweeps/3163/console for details)

mentioned in merge request !57061 (merged)

mentioned in commit 18599aac