Skip to content
Snippets Groups Projects

Draft: ParticleJetTools: Fix AsgDataHandles / StoreGate typo.

Closed Dan Guest requested to merge dguest/athena:cherry-pick-cherry-pick into 22.0
1 unresolved thread

Pulled off !56793 (merged).

Edited by Dan Guest

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • This merge request affects 1 package:

    • PhysicsAnalysis/AnalysisCommon/ParticleJetTools

    This merge request affects 1 file:

    • PhysicsAnalysis/AnalysisCommon/ParticleJetTools/ParticleJetTools/ParticleJetLabelCommon.h

    Adding @jveatch as watcher

    • Hi @dguest - I'm afraid this isn't enough.

      /home/emoyse/atlas/athena_2/PhysicsAnalysis/AnalysisCommon/ParticleJetTools/Root/ParticleJetLabelCommon.cxx: In constructor 'ParticleJetTools::IParticleLinker::IParticleLinker(const SG::ReadHandleKey<DataVector<xAOD::TruthParticle_v1> >&, const string&)':
      /home/emoyse/atlas/athena_2/PhysicsAnalysis/AnalysisCommon/ParticleJetTools/Root/ParticleJetLabelCommon.cxx:108:15: error: 'const class SG::ReadHandleKey<DataVector<xAOD::TruthParticle_v1> >' has no member named 'hashedKey'
        108 |     m_key(key.hashedKey()),
            |               ^~~~~~~~~
      make[2]: *** [PhysicsAnalysis/AnalysisCommon/ParticleJetTools/CMakeFiles/ParticleJetToolsLib.dir/Root/ParticleJetLabelCommon.cxx.o] Error 1
      make[2]: *** Waiting for unfinished jobs....
      [ 85%] Generating ParticleJetToolsDictReflexDict.cxx

      Since I'm not sure what this code is supposed to do, and I have very little time tonight, I think I need to drop your change from the sweep !56793 (merged) . Can I suggest you develop it in master,AnalysisBase and then cherry-pick (or whatever) to 22.0?

    • Author Developer

      Sure I can do that. I guess this must have been discussed somewhere, but if we're going to make sweeps from 22.0 to master standard, shouldn't we run AnalysisBase CI jobs in 22.0?

    • Please register or sign in to reply
  • :white_check_mark: CI Result SUCCESS (hash 7e1583f5)

    Athena DetCommon
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 59096]

  • Dan Guest marked this merge request as draft

    marked this merge request as draft

  • closed

Please register or sign in to reply
Loading