ISF_FatrasToolsG4: thread-safety fixes

• Thread-safe initialization of G4RunManager
• PDGToG4Particle: make particle initialization thread-safe
• remove unnecessary mutables
• prefer objects on the stack over member variables

This merge request affects 1 package:

• Simulation/ISF/ISF_Fatras/ISF_FatrasToolsG4

This merge request affects 7 files:

• Simulation/ISF/ISF_Fatras/ISF_FatrasToolsG4/ISF_FatrasToolsG4/ATLAS_CHECK_THREAD_SAFETY
• Simulation/ISF/ISF_Fatras/ISF_FatrasToolsG4/ISF_FatrasToolsG4/G4HadIntProcessor.h
• Simulation/ISF/ISF_Fatras/ISF_FatrasToolsG4/ISF_FatrasToolsG4/G4ParticleDecayHelper.h
• Simulation/ISF/ISF_Fatras/ISF_FatrasToolsG4/ISF_FatrasToolsG4/PDGToG4Particle.h
• Simulation/ISF/ISF_Fatras/ISF_FatrasToolsG4/src/G4HadIntProcessor.cxx
• Simulation/ISF/ISF_Fatras/ISF_FatrasToolsG4/src/G4ParticleDecayHelper.cxx
• Simulation/ISF/ISF_Fatras/ISF_FatrasToolsG4/src/PDGToG4Particle.cxx

Adding @jchapman ,@tcuhadar ,@lmijovic as watchers

added Simulation master review-pending-level-1 labels

CI Result SUCCESS (hash b18f55ec)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 59109]

MR looks good to me, CI was passed. Approving.

Cheers, Martin (L1)

added review-approved label and removed review-pending-level-1 label

mentioned in commit b542db09

merged

added sweep:ignore label