JiveXML: Fix cppcheck warnings.

Fix cppcheck warnings.

This merge request affects 1 package:

• graphics/JiveXML

This merge request affects 14 files:

• graphics/JiveXML/JiveXML/EventStream.h
• graphics/JiveXML/JiveXML/ExternalONCRPCServerSvc.h
• graphics/JiveXML/JiveXML/IEventReceiver.h
• graphics/JiveXML/JiveXML/IEventServer.h
• graphics/JiveXML/JiveXML/IFormatTool.h
• graphics/JiveXML/JiveXML/IMessage.h
• graphics/JiveXML/JiveXML/ONCRPCServer.h
• graphics/JiveXML/JiveXML/ONCRPCServerProcs.h
• graphics/JiveXML/JiveXML/ONCRPCServerSvc.h
• graphics/JiveXML/JiveXML/XMLFormatTool.h
• graphics/JiveXML/src/ExternalONCRPCServerSvc.cxx
• graphics/JiveXML/src/ONCRPCServerProcs.cxx
• graphics/JiveXML/src/ONCRPCServerSvc.cxx
• graphics/JiveXML/src/XMLFormatTool.cxx

Adding @rbianchi as watcher

added EventDisplay master review-pending-level-1 labels

CI integration tests for projects Athena are cancelled because of compilation error(s)

CI Result FAILURE (hash 5d5e5ada)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 1, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 59258]

Hi @ssnyder the compilation has problems and warnings. There is in particular this:

/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/HLT/Services/JiveXMLServer/bin/jivexmlserver.cc: In function 'int main(int, char**)':
/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/HLT/Services/JiveXMLServer/bin/jivexmlserver.cc:52:26: error: cannot declare variable 'server' to be of abstract type 'JiveXML::JiveXMLServer'
   52 |   JiveXML::JiveXMLServer server;

Can you address these problems?

-- L1

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• 37dcd180 - Propagate interface changes to JiveXMLServer.

Compare with previous version

This merge request affects 2 packages:

• HLT/Services/JiveXMLServer
• graphics/JiveXML

Affected files list will not be printed in this case

Adding @wiedenma ,@bernius ,@fwinkl ,@rbielski ,@rbianchi as watchers

added Trigger review-pending-level-1 labels and removed review-user-action-required label

CI Result SUCCESS (hash 37dcd180)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 59301]

Changes look fine and CI is good. Approving. Clara (L1)

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 389ae788

added sweep:ignore label