AsgElectronEfficiency : add override/final, modify interface, make tests work via a Handle

Asg Electron Efficiency

• add override/final
• The public method are now part of the interface (others moved to private)
• In the tests (using the StandAlone Tool Handle ) , test what the users interact with , the interface via handles .

changed title from Asg Electron Efficiency add override/final, modify interface, make tests work via the interface to AsgElectronEfficiency : add override/final, modify interface, make tests work via a Handle

build area is cleaned as the previous build was for the MR labeled as full-build

This merge request affects 2 packages:

• PhysicsAnalysis/ElectronPhotonID/ElectronEfficiencyCorrection
• PhysicsAnalysis/Interfaces/EgammaAnalysisInterfaces

Affected files list will not be printed in this case

Adding @akraszna as watcher

added Analysis Egamma analysis-review-required master review-pending-level-1 labels

added 1 commit

• f82ea63a - update copyrights

Compare with previous version

This merge request affects 2 packages:

• PhysicsAnalysis/ElectronPhotonID/ElectronEfficiencyCorrection
• PhysicsAnalysis/Interfaces/EgammaAnalysisInterfaces

Affected files list will not be printed in this case

Adding @akraszna as watcher

added 1 commit

• 543d44eb - cache more of the systematics we already know

Compare with previous version

This merge request affects 2 packages:

• PhysicsAnalysis/ElectronPhotonID/ElectronEfficiencyCorrection
• PhysicsAnalysis/Interfaces/EgammaAnalysisInterfaces

Affected files list will not be printed in this case

Adding @akraszna as watcher

CI integration tests for projects Athena,AnalysisBase,AthAnalysis are cancelled because of compilation error(s)

CI Result FAILURE (hash 543d44eb)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 1, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 1, warnings 0
AthAnalysis: number of compilation errors 1, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 59335]

added 1 commit

• 1d54902d - fix dummy in the TrigGlobalEffTool

Compare with previous version

This merge request affects 3 packages:

• PhysicsAnalysis/ElectronPhotonID/ElectronEfficiencyCorrection
• PhysicsAnalysis/Interfaces/EgammaAnalysisInterfaces
• Trigger/TrigAnalysis/TrigGlobalEfficiencyCorrection

Affected files list will not be printed in this case

Adding @akraszna as watcher

added Trigger label

CI integration tests for projects Athena,AnalysisBase,AthAnalysis are cancelled because of compilation error(s)

CI Result FAILURE (hash f82ea63a)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 1, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 1, warnings 0
AthAnalysis: number of compilation errors 1, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 59332]

CI integration tests for projects Athena,AnalysisBase,AthAnalysis are cancelled because of compilation error(s)

CI Result FAILURE (hash 6ae26d35)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 1, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 1, warnings 0
AthAnalysis: number of compilation errors 1, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 59323]

CI Result SUCCESS (hash 1d54902d)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 59337]

Looks good, thus approving. L1

added review-approved label and removed review-pending-level-1 label