ATLASRECTS-7305: fixes for large cluster building

This MR fixes bugs in the large cluster builder tool in EGamma, used to keep rectangles of 7x11 (S2 granularity) cells in AOD (for central electron and photon studies) (Large clusters in the fwd region are also built for the purpose of keeping cells, but the bugs in that part should be harmless.)

This has no effect on reconstructed quantities, only the size of the AllCalo cell container in AOD should increase a bit, and maybe links from clusters to cells will be reshuffled.

added 22.0 Egamma Reconstruction frozen-tier0-violating labels

Jenkins please retry a build

This merge request affects 1 package:

• Reconstruction/egamma/egammaTools

This merge request affects 1 file:

• Reconstruction/egamma/egammaTools/src/egammaLargeClusterMaker.cxx

Adding @goetz as watcher

added Run2-DataReco-output-changed Run3-DataReco-output-changed Run3-MCReco-output-changed labels

CI Result FAILURE (hash 87d67e01)

	Athena	DetCommon
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 59523]

marked this merge request as ready

The CI test failures are expected (changed in AllCalo, and links). The large clusters (711 and 66FWD) stored in ESD are also expected to change.

Let me ping @jmaurer for the references.

From what I understood from @ludovica , @turra

we just had a quick chat with PC, and actually indeed we will have the cells back for the fast reprocessing of November for MC21 and Run3 data." Let me ping @gunal.

Anyhow, this indeed changes the all cells in AOD as we keep more of them , more extra ones, and will re-swizzle indices

ERROR    Py:diff-root         INFO  [AllCalo.m_compactData]: 131755 leaves differ
ERROR    Py:diff-root         INFO  [CaloCalTopoClusters_links.m_indices]: 22661 leaves differ
ERROR    Py:diff-root         INFO  [ForwardElectronClusters_links.m_indices]: 3327 leaves differ
ERROR    Py:diff-root         INFO  [InDetTrackParticlesAssociatedClusters_links.m_indices]: 334 leaves differ
ERROR    Py:diff-root         INFO  [LRTegammaClusters_links.m_indices]: 329 leaves differ
ERROR    Py:diff-root         INFO  [MuonClusterCollection_links.m_indices]: 731 leaves differ
ERROR    Py:diff-root         INFO  [TauPi0Clusters_links.m_indices]: 24883 leaves differ
ERROR    Py:diff-root         INFO  [TauShotClusters_links.m_indices]: 2882 leaves differ
ERROR    Py:diff-root         INFO  [egammaClusters_links.m_indices]: 20405 leaves differ

is what we expect

The reason this will break FT0 is that will change the size of AllCalo cells in AOD and the relevant indices. But will change nothing on any object (egamma or otherwise) or clusters (other than indices to cells).

Should wait a bit with the reference update since !57073 (merged) for example should probably go in before. I understood this can anyway wait until discussion in the reco meeting next week?

Hi need to check the meeting for next week as will be S&C week so things have moved around a bit. But it can wait for other MRs that change these to go in first.

added 1 commit

• 7fd3d37c - adding an ET cut on input cluster to produce large clusters

Compare with previous version

This merge request affects 1 package:

• Reconstruction/egamma/egammaTools

This merge request affects 2 files:

• Reconstruction/egamma/egammaTools/src/egammaLargeClusterMaker.cxx
• Reconstruction/egamma/egammaTools/src/egammaLargeClusterMaker.h

Adding @goetz as watcher

added review-pending-level-1 label

added 1 commit

• 206ac890 - better catch weird input fwd clusters that would not give large fwd clusters

Compare with previous version

This merge request affects 1 package:

• Reconstruction/egamma/egammaTools

This merge request affects 2 files:

• Reconstruction/egamma/egammaTools/src/egammaLargeClusterMaker.cxx
• Reconstruction/egamma/egammaTools/src/egammaLargeClusterMaker.h

Adding @goetz as watcher

CI integration tests for projects Athena are cancelled because of compilation error(s)

added 1 commit

• 5576ebed - fix

Compare with previous version

CI Result FAILURE (hash 206ac890)

	Athena	DetCommon
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 1, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 59606]

There were multiple CI triggers for this MR and commit. The system ignored duplicates but the GitLab pipeline status may incorrectly show the job as failed. Once the remaining job finished running, the CI results will be posted as usual.

This merge request affects 1 package:

• Reconstruction/egamma/egammaTools

This merge request affects 2 files:

• Reconstruction/egamma/egammaTools/src/egammaLargeClusterMaker.cxx
• Reconstruction/egamma/egammaTools/src/egammaLargeClusterMaker.h

Adding @goetz as watcher

CI Result FAILURE (hash 7fd3d37c)

	Athena	DetCommon
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 59594]

CI Result FAILURE (hash 5576ebed)

	Athena	DetCommon
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 59612]