Skip to content
Snippets Groups Projects

Introduction of NSW L1 Simulation converters

Merged Francesco Giuseppe Gravili requested to merge fgravili/athena:cnv into 22.0
All threads resolved!

This important MR introduces all the necessary converters to invoke transient/persistent representation scheme and related conversion functions. The structure and inheritance scheme of the newly added persistent classes follow the same pattern as the corresponding ones in the MuonRDO package.

Other related changes:

  • The NSW_TrigRawDataSegment class was modified to include the channel list in a given coincidence, as done in !54486 (merged) but never backported to atlas/athena:22.0 branch
  • The selection.xml file was modified introducing an UUID for the _v1 persistent representation, generated using the uuidgen command
  • As the converters are now available, the NSW trigger RDO is written into the general MuonL1Simulation output file
  • The NSW trigger RDO is added to the PerfDESDM_MS.py to be included in the DESD reduction stream

Conversion in both directions, i.e. transient <-> persistent, was successfully tested and a dedicated tool is under development, to be included in the MuonTester package.

./cc-ing @rosati @iodice @vadamico @sfrances

Merge request reports

Checking pipeline status.

Approval is optional

Merged by Marija Vranjes MilosavljevicMarija Vranjes Milosavljevic 2 years ago (Oct 18, 2022 8:21am UTC)

Merge details

  • Changes merged into 22.0 with 1392a693 (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 7 commits

    • e776ee10 - Reverted where the NSW_TrigRawDataContainer is written out
    • a3786136 - Fixed for-loop incrementing index
    • d6b7ec5b - Added default constructor
    • c0db8c50 - Added default constructor and private member initialisation values
    • 01786c94 - Added default destructor, initialisation and const reference
    • f7718419 - Added override specifier
    • a96f979e - Added default constructor and initialisation values

    Compare with previous version

  • This merge request affects 4 packages:

    • MuonSpectrometer/MuonCnv/MuonEventAthenaPool
    • MuonSpectrometer/MuonCnv/MuonEventTPCnv
    • MuonSpectrometer/MuonRDO
    • PhysicsAnalysis/PrimaryDPDMaker

    Affected files list will not be printed in this case

    Adding @rosati ,@wleight ,@stavrop ,@jojungge ,@apsallid ,@pscholer as watchers

  • :white_check_mark: CI Result SUCCESS (hash a96f979e)

    Athena DetCommon
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 60446]

  • Johannes Junggeburth resolved all threads

    resolved all threads

  • Approved
    Albert (L1)

  • added review-approved label and removed review-pending-level-1 label

  • mentioned in commit 1392a693

  • resolved all threads

  • Hi @fgravili , this MR generates some conflicts with the master on MuonSpectrometer/MuonRDO/MuonRDO/NSW_TrigRawDataSegment.h. I'm not sure how I'm supposed to deal with these conflicts. Could you please try to merge the latest version of 22.0 with the master in your work area, examine the conflicts, and let me know how I should deal with them? Thank you.

  • Vakhtang Tsulaia mentioned in merge request !57680 (merged)

    mentioned in merge request !57680 (merged)

  • resolved all threads

  • Please register or sign in to reply
    Loading