Introduction of NSW L1 Simulation converters
This important MR introduces all the necessary converters to invoke transient/persistent representation scheme and related conversion functions. The structure and inheritance scheme of the newly added persistent classes follow the same pattern as the corresponding ones in the MuonRDO
package.
Other related changes:
- The
NSW_TrigRawDataSegment
class was modified to include the channel list in a given coincidence, as done in !54486 (merged) but never backported toatlas/athena:22.0
branch - The
selection.xml
file was modified introducing an UUID for the _v1 persistent representation, generated using theuuidgen
command - As the converters are now available, the NSW trigger RDO is written into the general MuonL1Simulation output file
- The NSW trigger RDO is added to the
PerfDESDM_MS.py
to be included in the DESD reduction stream
Conversion in both directions, i.e. transient <-> persistent, was successfully tested and a dedicated tool is under development, to be included in the MuonTester
package.
Merge request reports
Activity
This merge request affects 5 packages:
- MuonSpectrometer/MuonCnv/MuonEventAthenaPool
- MuonSpectrometer/MuonCnv/MuonEventTPCnv
- MuonSpectrometer/MuonRDO
- PhysicsAnalysis/PrimaryDPDMaker
- Trigger/TriggerCommon/TriggerJobOpts
Affected files list will not be printed in this case
Adding @martindl ,@rosati ,@wleight ,@stavrop ,@jojungge ,@apsallid ,@pscholer ,@rbielski as watchers
added 22.0 Analysis MuonSpectrometer Trigger review-pending-level-1 labels
CI Result SUCCESS (hash 30022a56)Athena DetCommon externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 60306]- Resolved by Francesco Giuseppe Gravili
- Resolved by Francesco Giuseppe Gravili
- Resolved by Francesco Giuseppe Gravili
- Resolved by Francesco Giuseppe Gravili
- Resolved by Francesco Giuseppe Gravili
- Resolved by Francesco Giuseppe Gravili
- Resolved by Francesco Giuseppe Gravili
- Resolved by Francesco Giuseppe Gravili
removed review-pending-level-1 label
added review-user-action-required label
- Resolved by Francesco Giuseppe Gravili
added 7 commits
- e776ee10 - Reverted where the NSW_TrigRawDataContainer is written out
- a3786136 - Fixed for-loop incrementing index
- d6b7ec5b - Added default constructor
- c0db8c50 - Added default constructor and private member initialisation values
- 01786c94 - Added default destructor, initialisation and const reference
- f7718419 - Added override specifier
- a96f979e - Added default constructor and initialisation values
Toggle commit listThis merge request affects 4 packages:
- MuonSpectrometer/MuonCnv/MuonEventAthenaPool
- MuonSpectrometer/MuonCnv/MuonEventTPCnv
- MuonSpectrometer/MuonRDO
- PhysicsAnalysis/PrimaryDPDMaker
Affected files list will not be printed in this case
Adding @rosati ,@wleight ,@stavrop ,@jojungge ,@apsallid ,@pscholer as watchers
added review-pending-level-1 label and removed review-user-action-required label
CI Result SUCCESS (hash a96f979e)Athena DetCommon externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 60446]added review-approved label and removed review-pending-level-1 label
added review-approved-tier0 label
added review-approved-point1 label
mentioned in commit 1392a693
Hi @fgravili , this MR generates some conflicts with the master on
MuonSpectrometer/MuonRDO/MuonRDO/NSW_TrigRawDataSegment.h
. I'm not sure how I'm supposed to deal with these conflicts. Could you please try to merge the latest version of 22.0 with the master in your work area, examine the conflicts, and let me know how I should deal with them? Thank you.- Resolved by Francesco Giuseppe Gravili
Hi @tsulaia, as I wrote in the description, some changes were already pushed to the master branch before. But I can certainly say that it's 100% safe to overwrite all that was done before, completely replacing the previous file by the one in this MR. Thanks in advance
Edited by Francesco Giuseppe Gravili
mentioned in merge request !57680 (merged)