Fix setting of maximum ROOT output buffer sizes when relying on auto-flush (ie no SharedWriter)

This will limit buffer size for the very largest branches, helping to save memory.

added full-integration-tests full-unit-tests labels

requested review from @amete

This merge request affects 1 package:

• Database/APR/RootStorageSvc

This merge request affects 1 file:

• Database/APR/RootStorageSvc/src/RootDatabase.cpp

Adding @mnowak ,@ssnyder as watchers

added Database master review-pending-level-1 labels

Thanks a lot @gemmeren. The changes look good and we can proceed w/ everything as is. Having said that, I'm running some local tests to see the practical impact. I'll post the results when I get them.

approved this merge request

Thanks @amete ,

Yes, these tests are important, however if it turns out the max buffer size isn't good, we remove the setting in https://acode-browser1.usatlas.bnl.gov/lxr/source/athena/Reconstruction/RecExample/RecExCommon/share/RecoUtils.py#0186

I am hopeful that running on AOD written with the smaller buffer size will lower memory needed by derivation. We can also check on whether it helps ROOT IMT, but since output isn't really a bottleneck, that may be less important.

Peter

added alsoTargeting:22.0 label

CI Result SUCCESS (hash 0fbad005)

	Athena	AthSimulation	AthGeneration	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
NEW: project list is tailored to contain projects affected by code changes
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 60924]

Approved
Albert (L1)

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit a7ab6df2

added sweep:done label

picked the changes into the branch cherry-pick-a7ab6df25c8-22.0 with commit 8eb928f8

mentioned in commit 8eb928f8

mentioned in merge request !57911 (merged)

Sweep summary
successful:

• 22.0

(see https://aiatlas154.cern.ch/jenkins/job/auto_git_sweeps/3284/console for details)

mentioned in commit a804fa29