CalibrationDataInterface+BTaggingEfficiencyTool: remove mutables and const fixes

Most of the classes use internal caching by modifying mutables in const functions. Remove the mutables in favor of making the interfaces non-const to make it clear that these methods are not thread-safe.

Enable thread-checker.

Build area was cleaned as per request posted in the DB. The full software build will be performed

This merge request affects 1 package:

• PhysicsAnalysis/JetTagging/JetTagPerformanceCalibration/CalibrationDataInterface

This merge request affects 8 files:

• PhysicsAnalysis/JetTagging/JetTagPerformanceCalibration/CalibrationDataInterface/CMakeLists.txt
• PhysicsAnalysis/JetTagging/JetTagPerformanceCalibration/CalibrationDataInterface/CalibrationDataInterface/ATLAS_CHECK_THREAD_SAFETY
• PhysicsAnalysis/JetTagging/JetTagPerformanceCalibration/CalibrationDataInterface/CalibrationDataInterface/CalibrationDataContainer.h
• PhysicsAnalysis/JetTagging/JetTagPerformanceCalibration/CalibrationDataInterface/CalibrationDataInterface/CalibrationDataEigenVariations.h
• PhysicsAnalysis/JetTagging/JetTagPerformanceCalibration/CalibrationDataInterface/CalibrationDataInterface/CalibrationDataInterfaceROOT.h
• PhysicsAnalysis/JetTagging/JetTagPerformanceCalibration/CalibrationDataInterface/Root/CalibrationDataContainer.cxx
• PhysicsAnalysis/JetTagging/JetTagPerformanceCalibration/CalibrationDataInterface/Root/CalibrationDataEigenVariations.cxx
• PhysicsAnalysis/JetTagging/JetTagPerformanceCalibration/CalibrationDataInterface/Root/CalibrationDataInterfaceROOT.cxx

added Analysis BTagging JetEtmiss analysis-review-required master review-pending-level-1 labels

WARNING: big files (>100K) are found in the changeset

128K in file PhysicsAnalysis/JetTagging/JetTagPerformanceCalibration/CalibrationDataInterface/Root/CalibrationDataInterfaceROOT.cxx

I would like this to be reviewed by the relevant expert. Not clear who that would be. Tagging FTag conveners: @fdibello @biliu

CI Result FAILURE (hash 6515e9a0)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
NEW: project list is tailored to contain projects affected by code changes
Athena: number of compilation errors 0, warnings 1
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 61137]

removed review-pending-level-1 label

added review-user-action-required label

marked this merge request as draft

added 2 commits

• 64a22b45 - CalibrationDataInterface: remove mutables and const fixes
• 011d912a - BTaggingEfficiencyTool: make interfaces non-const

Compare with previous version

changed title from Draft: CalibrationDataInterface: remove mutables and const fixes to Draft: CalibrationDataInterface+BTaggingEfficiencyTool: remove mutables and const fixes

marked this merge request as ready

This merge request affects 3 packages:

• PhysicsAnalysis/Interfaces/FTagAnalysisInterfaces
• PhysicsAnalysis/JetTagging/JetTagPerformanceCalibration/CalibrationDataInterface
• PhysicsAnalysis/JetTagging/JetTagPerformanceCalibration/xAODBTaggingEfficiency

Affected files list will not be printed in this case

Adding @duperrin ,@akraszna ,@dguest ,@bdong ,@lidiaz as watchers

added Derivation review-pending-level-1 labels and removed review-user-action-required label

WARNING: big files (>100K) are found in the changeset

128K in file PhysicsAnalysis/JetTagging/JetTagPerformanceCalibration/CalibrationDataInterface/Root/CalibrationDataInterfaceROOT.cxx

I don't know if the patch will apply to 22.0, since that's analysis code that we may have let languish in 22.0. But there's no good reason to let it go out of sync so let's see if it can be swept.

added alsoTargeting:22.0 label

CI integration tests for projects AnalysisBase are cancelled because of compilation error(s)

CI Result FAILURE (hash 011d912a)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
NEW: project list is tailored to contain projects affected by code changes
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 1, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 61146]

added 1 commit

• 569aabad - SUSYTools: make BtagSF[_trkJet] non-const

Compare with previous version

This merge request affects 4 packages:

• PhysicsAnalysis/Interfaces/FTagAnalysisInterfaces
• PhysicsAnalysis/JetTagging/JetTagPerformanceCalibration/CalibrationDataInterface
• PhysicsAnalysis/JetTagging/JetTagPerformanceCalibration/xAODBTaggingEfficiency
• PhysicsAnalysis/SUSYPhys/SUSYTools

Affected files list will not be printed in this case

Adding @zmarshal ,@duperrin ,@cmerlass ,@cohm ,@salderwe ,@szambito ,@mrimoldi ,@akraszna ,@janders ,@dguest ,@bdong ,@lidiaz as watchers

added SUSYTools label

WARNING: big files (>100K) are found in the changeset

128K in file PhysicsAnalysis/JetTagging/JetTagPerformanceCalibration/CalibrationDataInterface/Root/CalibrationDataInterfaceROOT.cxx

CI Result SUCCESS (hash 569aabad)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
NEW: project list is tailored to contain projects affected by code changes
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 61151]

resolved all threads

Except for the tiny comment looks good to me.

added review-user-action-required label and removed review-pending-level-1 label

added 128 commits

• 569aabad...28da07a9 - 125 commits from branch atlas:master
• 30e22f8a - CalibrationDataInterface: remove mutables and const fixes
• 834d912a - BTaggingEfficiencyTool: make interfaces non-const
• 864cdc88 - SUSYTools: make BtagSF[_trkJet] non-const

Compare with previous version

resolved all threads

This merge request affects 4 packages:

• PhysicsAnalysis/Interfaces/FTagAnalysisInterfaces
• PhysicsAnalysis/JetTagging/JetTagPerformanceCalibration/CalibrationDataInterface
• PhysicsAnalysis/JetTagging/JetTagPerformanceCalibration/xAODBTaggingEfficiency
• PhysicsAnalysis/SUSYPhys/SUSYTools

Affected files list will not be printed in this case

Adding @zmarshal ,@duperrin ,@cmerlass ,@cohm ,@salderwe ,@szambito ,@mrimoldi ,@akraszna ,@janders ,@dguest ,@bdong ,@lidiaz as watchers

added review-pending-level-1 label and removed review-user-action-required label

WARNING: big files (>100K) are found in the changeset

128K in file PhysicsAnalysis/JetTagging/JetTagPerformanceCalibration/CalibrationDataInterface/Root/CalibrationDataInterfaceROOT.cxx

Build area was cleaned as per request posted in the DB. The full software build will be performed

There were multiple CI triggers for this MR and commit. The system ignored duplicates but the GitLab pipeline status may incorrectly show the job as failed. Once the remaining job finished running, the CI results will be posted as usual.

CI Result FAILURE (hash 864cdc88)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 61256]

Jenkins please retry a build

This merge request affects 4 packages:

• PhysicsAnalysis/Interfaces/FTagAnalysisInterfaces
• PhysicsAnalysis/JetTagging/JetTagPerformanceCalibration/CalibrationDataInterface
• PhysicsAnalysis/JetTagging/JetTagPerformanceCalibration/xAODBTaggingEfficiency
• PhysicsAnalysis/SUSYPhys/SUSYTools

Affected files list will not be printed in this case

Adding @zmarshal ,@duperrin ,@cmerlass ,@cohm ,@salderwe ,@szambito ,@mrimoldi ,@akraszna ,@janders ,@dguest ,@bdong ,@lidiaz as watchers

WARNING: big files (>100K) are found in the changeset

128K in file PhysicsAnalysis/JetTagging/JetTagPerformanceCalibration/CalibrationDataInterface/Root/CalibrationDataInterfaceROOT.cxx

CI Result SUCCESS (hash 864cdc88)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 61305]

Looks good. Approved

Sergei L1

added review-approved label and removed review-pending-level-1 label

added analysis-review-approved label and removed analysis-review-required label

merged

mentioned in commit 5dafdbd9

added sweep:done label

picked the changes into the branch cherry-pick-5dafdbd9cf8-22.0 with commit a8187fbb

mentioned in commit a8187fbb

Sweep summary
successful:

• 22.0

(see https://aiatlas154.cern.ch/jenkins/job/auto_git_sweeps/3313/console for details)

mentioned in merge request !58093 (merged)