Removing two obsolete lists in DAOD SlimmingHelper

The two lists of containers FullListOfSmartContainers and StaticNamesAndTypes are no longer needed in the slimming machinery, and are removed. The former was not used for anything, whereas the second was used in the event that the file metadata didn't have the list of named types. Since this should always be available, this can be safely dropped.

added Derivation master labels

This merge request affects 1 package:

• PhysicsAnalysis/DerivationFramework/DerivationFrameworkCore

This merge request affects 4 files:

• PhysicsAnalysis/DerivationFramework/DerivationFrameworkCore/README.md
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkCore/python/FullListOfSmartContainers.py
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkCore/python/SlimmingHelper.py
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkCore/python/StaticNamesAndTypes.py

Adding @jcatmore ,@calpigia as watchers

added review-pending-level-1 label

The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)AF3.*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

CI Result SUCCESS (hash e0469e1f)

	Athena	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
NEW: project list is tailored to contain projects affected by code changes
Athena: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 61160]

Looks good. Karolos (L2)

added review-approved label and removed review-pending-level-1 label

mentioned in commit 8b5c3ce0

merged

added sweep:ignore label

Hi @jcatmore,

many CI jobs are failing now with:

 File "/build2/ci-builds/master/Athena/build/Athena/x86_64-centos7-gcc11-opt/python/DerivationFrameworkCore/SlimmingHelper.py", line 76, in buildNamesAndTypes
  14:51:20     raise RuntimeError("Unable to find the names and types list... for CA jobs check you passed ConfigFlags.Input.TypedCollections to slimming helper")

Could that be related to this MR?

• Walter

Hi @wlampl ,

yes, this will be the cause of these errors

The issue is in the legacy IDTIDE format, which is being tested in the reco CI. It seems that for the workflows that don't have AOD as input, the following typed list isn't available after all:

inputFileSummary['eventdata_items']

Prior to this MR it fell back to a hardcoded list, which I removed thinking it was obsolete (and the tests were passed because the reco workflow wasn't tested). Hence the crash now.

There are two options:

• take IDTIDE out of the CI and put it back once the CA migration is done
• revert this MR

I guess the latter is the best option... I guess we'll have to live with these legacy things for a bit longer.

Sorry for this.

James.

mentioned in commit e8aab08c

Ok, I'll revert this for now.

• Walter