RootStorageSvc+PersistencySvc: remove unused RootDomain options

Remove the following (mostly) unused options in RootDomain because they are modifying ROOT globals and causing thread-checker warnings:

• ASYNC_PREFETCHING
• ABORT_LEVEL
• ERROR_LEVEL

Only the last one was being used in the standalone SimpleUtilityBase and is now set there directly.

cc @ssnyder @gemmeren @mnowak

added full-unit-tests label

This merge request affects 2 packages:

• Database/APR/PersistencySvc
• Database/APR/RootStorageSvc

Affected files list will not be printed in this case

Adding @mnowak ,@ssnyder as watchers

added Database master review-pending-level-1 labels

CI Result SUCCESS (hash ae9712b1)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 61374]

removed review-pending-level-1 label

removed full-unit-tests label

added 17 commits

• ae9712b1...8c90147b - 14 commits from branch atlas:master
• f96301a6 - RootStorageSvc: remove unused options
• 17f2f345 - RootStorageSvc+PersistencySvc: remove ERROR_LEVEL option
• 6b6305e4 - AtlCoolCopy: suppress thread-checker warnings

Compare with previous version

This merge request affects 3 packages:

• Database/APR/PersistencySvc
• Database/APR/RootStorageSvc
• Database/CoolConvUtilities

Affected files list will not be printed in this case

Adding @mnowak ,@ssnyder as watchers

added review-pending-level-1 label

WARNING: big files (>100K) are found in the changeset

124K in file Database/CoolConvUtilities/src/AtlCoolCopy.cxx

Hi @fwinkl ,

I am not super excited about removing the ASYNC_PREFETCHING setting. We do not currently use it in any production workflows, but we have done some studies in the past and it may be beneficial to have it in future. Note: These settings are applied during initialize or on the first event, ie when things are still in serial. Let me tag @mnowak maybe there is a way around the thread-checker warnings w/o losing the capability of using ROOT's asynchronous prefetch (at some point).

Thanks, Peter

CI Result SUCCESS (hash 6b6305e4)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 61398]

removed review-pending-level-1 label

added review-user-action-required label

resolved all threads

removed review-user-action-required label

added review-pending-level-1 label

resolved all threads

Looks good, approving - L1

added review-approved label and removed review-pending-level-1 label