Skip to content

fix of TgcCoinData and extention to NextNextBC

Masato Aoki requested to merge masato/athena:22.0-masato_tgcDecording into 22.0

The TgcCoinData container in the current release is having a lot of bugs and is useless for offline trigger analysis. This MR is to fix these bugs, and also to extend the output to Next-to-Next Bunch Crossing. This NextNextBC is a new feature of Run3 TGC trigger readout, and it has been available in the Bytestream data since the beginning of Run3, but it was not implemented in ESD. The TgcCoinData is used only by TGC experts to study the trigger performance and to tune the trigger roads. Also, this is very important data for validating the inner coincidence with Tile, NSW, and RPC BIS78. So we would like to have this MR in the release as soon as possible.

I ran the CI tests locally, and I saw basically changes in the TgcCoinData container, as expected.

I just wanted to note that this change does change the content of the TgcPrepDataContainer, but the CI failed due to some changes with this container.

ERROR    Py:diff-root         INFO  [Muon::MuonPRD_Container_p2<Muon::TgcPrepData_p3>_TGC_MeasurementsAllBCs.m_collections.m_size]: 2 leaves differ
ERROR    Py:diff-root         INFO  [Muon::MuonPRD_Container_p2<Muon::TgcPrepData_p3>_TGC_MeasurementsAllBCs.m_prdDeltaId]: 178 leaves differ
ERROR    Py:diff-root         INFO  [Muon::MuonPRD_Container_p2<Muon::TgcPrepData_p3>_TGC_MeasurementsAllBCs.m_prds.m_bcBitMap]: 64 leaves differ
ERROR    Py:diff-root         INFO  [Muon::MuonPRD_Container_p2<Muon::TgcPrepData_p3>_TGC_MeasurementsAllBCs.m_prds.m_errorMat]: 171 leaves differ
ERROR    Py:diff-root         INFO  [Muon::MuonPRD_Container_p2<Muon::TgcPrepData_p3>_TGC_MeasurementsAllBCs.m_prds.m_locX]: 179 leaves differ

Seems this is an effect of the caching algorithm, which was also reported in an old MR, !50914 (merged). So, this shouldn't be a problem.

It's my first time updating the EDM-related packages and indeed this breaks the tier0 frozen policy. I would applicate any suggestions. Note that the TgcCoinData is not used by the muon reconstruction or any physics analysis. TgcCoinData is saved only in EDS, not in AOD.

*This MR fixes ATLASRECTS-7299 too.

Edited by Masato Aoki

Merge request reports