23.0-debug-TrkTrack

A step in debugging ATLASRECTS-7335

Jenkins please retry a build.

• I think is good that GXFTrackState are moved next to the TSOS.

• Rather than running the danger to x-include and tie in the future our selves in knots. I would have had a factory method in GXFTrackState producing TSOS. Rather that an uber special converting ctor inside the TSOS.

• We do not want someone to wonder if the inheriting AlignTSOS or MultiComponentTSOS should implement it etc ... a GXF method returning TSOS ala a factory seemes neater .

• I would assume a factory can return something meaningful if insane is to be created

• For the "knots" we had the issue (if you recall) of the TrkParametersBase and Surfaces almost being cross inluded. Things depend on exact fwd declaration and re-factoring can be hard ...

• You add a couple of utilities that I would prb have moved either under TrkEventPrimitives or TrkEventUtils . Plus their test.

• The GXFMaterial not sure if they should go where other MaterialEffects classes are.

added 5 commits

• 9e7c51b4 - first attempt
• 3f933758 - first attempt
• 2676a6fd - shuffle positions around
• 67416874 - update GXFState with a TSOS method
• 9fe5305f - move unique_clone (uclone) to TrkEventPrimitives

Compare with previous version

Jenkins please retry a build

This merge request affects 3 packages:

• Tracking/TrkEvent/TrkEventPrimitives
• Tracking/TrkEvent/TrkTrack
• Tracking/TrkFitter/TrkGlobalChi2Fitter

Affected files list will not be printed in this case

Adding @amorley as watcher

added Tracking master labels

WARNING: big files (>100K) are found in the changeset

296K in file Tracking/TrkFitter/TrkGlobalChi2Fitter/src/GlobalChi2Fitter.cxx

resolved all threads

CI integration tests for projects AthGeneration are cancelled because of compilation error(s)

CI Result FAILURE (hash 9fe5305f)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 1, warnings 7
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 61663]

I set up AthGeneration; I cannot reproduce that compilation failure.

marked this merge request as ready

Jenkins please retry a build

This merge request affects 3 packages:

• Tracking/TrkEvent/TrkEventPrimitives
• Tracking/TrkEvent/TrkTrack
• Tracking/TrkFitter/TrkGlobalChi2Fitter

Affected files list will not be printed in this case

Adding @amorley as watcher

added review-pending-level-1 label