Skip to content
Snippets Groups Projects

Allow to turn FPE checks off

Merged Walter Lampl requested to merge wlampl/athena:allowNoFPECheck into master
All threads resolved!

Follow-up to !57793 (merged). The unit-test TrigEventAthenaPool_15.6.1_ctest fails with an FPE (invalid operation) that I can trace back to python's float_richcompare called from PyDumper/Dumpers.py. I suspect a invalid value in the input file.

As stopgap solution, this MR adds an option to turn FPE-checks entirely off and uses this option in TPCnvTestConfig.py

cc @tadej , @christos

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • This merge request affects 2 packages:

    • Control/AthenaConfiguration
    • Database/AthenaPOOL/AthenaPoolUtilities

    Affected files list will not be printed in this case

    Adding @ssnyder ,@mnowak as watchers

  • Tadej Novak resolved all threads

    resolved all threads

  • Walter Lampl mentioned in merge request !58198 (merged)

    mentioned in merge request !58198 (merged)

  • :white_check_mark: CI Result SUCCESS (hash ba00160d)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 61703]

  • merged

  • Tadej Novak mentioned in commit 068f8bbc

    mentioned in commit 068f8bbc

  • Hey

    to turn FPE-checks entirely off and uses this option in TPCnvTestConfig.py

    should we revert after @ssnyder [!58338 (merged)]

    or as part of it ?

  • Hi @christos,

    I'll give it a try ...

    • Walter
  • Walter Lampl mentioned in merge request !58426 (merged)

    mentioned in merge request !58426 (merged)

  • Please register or sign in to reply
    Loading