Skip to content
Snippets Groups Projects

ISF_Geant4Tools+ISF_FatrasToolsG4: thread-checker fixes

Merged ISF_Geant4Tools+ISF_FatrasToolsG4: thread-checker fixes
fwinkl/athena:g4tools into master
All threads resolved!
Merged Frank Winklmeier requested to merge fwinkl/athena:g4tools into master
All threads resolved!
  • Mark getters for G4RunManger in IG4RunManagerHelper as not thread-safe.
  • Remove unnecessary mutables in PhysicsValidationUserAction and const fix.
  • Remove unnecessary const_cast in TrackProcessorUserActionFullG4.
  • Update link dependencies.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • A
    Albert Kong @akong ·
    Developer

    Changes look fine; marking as review-user-action-required while the discussion thread is being resolved
    Albert (L1)

  • Albert Kong added review-user-action-required label and removed review-pending-level-1 label

    added review-user-action-required label and removed review-pending-level-1 label

  • Frank Winklmeier resolved all threads

    resolved all threads

  • Frank Winklmeier removed review-user-action-required label

    removed review-user-action-required label

  • Frank Winklmeier added review-pending-level-1 label

    added review-pending-level-1 label

  • Frank Winklmeier
    Frank Winklmeier @fwinkl ·
    Author Maintainer

    Jenkins please retry a build

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 2 packages:

    • Simulation/ISF/ISF_Fatras/ISF_FatrasToolsG4
    • Simulation/ISF/ISF_Geant4/ISF_Geant4Tools

    Affected files list will not be printed in this case

    Adding @jchapman ,@tcuhadar ,@lmijovic as watchers

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash a7c06448)

    Athena AthSimulation
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 61893]

  • Fang-Ying Tsai
    Fang-Ying Tsai @fatsai ·
    Developer

    Approved. L1

  • Fang-Ying Tsai added review-approved label and removed review-pending-level-1 label

    added review-approved label and removed review-pending-level-1 label

  • Adam Edward Barton mentioned in commit d52bbf39

    mentioned in commit d52bbf39

  • Adam Edward Barton merged

    merged

  • Atlas Nightlybuild added sweep:ignore label

    added sweep:ignore label

    • Please register or sign in to reply