Isolation selection pass non-const objects

Isolation selection pass non-const objects

Since this possibly made a full circle back to me.

Let revert the changes in the interface passing non-const and try to make the test run with copies

ping @schaffer , @goblirsc , @sabidi , @jojungge

The const_cast are still there this needs a different set of changes ...

This merge request affects 1 package:

• PhysicsAnalysis/AnalysisCommon/IsolationSelection

This merge request affects 5 files:

• PhysicsAnalysis/AnalysisCommon/IsolationSelection/IsolationSelection/IIsolationCloseByCorrectionTool.h
• PhysicsAnalysis/AnalysisCommon/IsolationSelection/IsolationSelection/IsolationCloseByCorrectionTool.h
• PhysicsAnalysis/AnalysisCommon/IsolationSelection/Root/IsolationCloseByCorrectionTool.cxx
• PhysicsAnalysis/AnalysisCommon/IsolationSelection/src/TestIsolationCloseByCorrAlg.cxx
• PhysicsAnalysis/AnalysisCommon/IsolationSelection/src/TestIsolationCloseByCorrAlg.h

Adding @stavrop ,@maklein ,@jojungge ,@mvanadia ,@fcardill ,@yoyamagu ,@fsforza ,@oducu ,@szambito ,@apsallid ,@gabarone ,@gartoni as watchers

added Analysis analysis-review-required master review-pending-level-1 labels

The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)AF3.*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

CI Result SUCCESS (hash c76e96c1)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 61872]

added analysis-review-approved label and removed analysis-review-required label

Looks good. Karolos (L2)

added review-approved label and removed review-pending-level-1 label

OK, looks good. Next step is to remove const_cast, as you say.

mentioned in commit fcc9263d

merged

It's astonishing that a const_cast is such a devil for the thread checker.

added sweep:ignore label

mentioned in merge request !58355 (closed)