Update large-R labelling for Xbb
Update the large-R JetTruthLabelingTool.cxx for use Xbb/cc. Based on discussions in !57667 (closed) (which is replaced by this MR) and on mattermost.
Changes:
- add Hcc, Zbb, Zcc categories
- add new label
R10TruthLabel_Xbbwhich is similar toR10TruthLabel_R21Precision_2022v1but contains the Hcc label, and uses theHadronConeExclExtendedTruthLabelIDinstead of counting theGhostBHadronsFinal/GhostCHadronsFinalfor the labelling which may be more robust. - some cleanup
Things to consider:
- Adding also a coarse set of labels which are better suited for Xbb training. This can also be done downstream in the FTAG training dataset dumper.
@fdibello @biliu @vdao @dguest @arelycg @vvecchio @jveatch @jcantero @mswiatlo @camacho @mleblanc
Merge request reports
Activity
This merge request affects 3 packages:
- PhysicsAnalysis/AnalysisCommon/ParticleJetTools
- PhysicsAnalysis/DerivationFramework/DerivationFrameworkJetEtMiss
- Reconstruction/Jet/JetRecConfig
Affected files list will not be printed in this case
Adding @goetz ,@jcatmore ,@calpigia ,@jmellent ,@cantel ,@jveatch ,@nelsonc ,@ispokhar as watchers
added alsoTargeting:22.0 label
mentioned in merge request !57667 (closed)
Resolved by Samuel Van StroudHi @svanstro,
First of all, apologies for not getting back to you about this sooner.
The changes look great. I just have two minor comments, otherwise I am happy with the changes. Thank you for taking care of this.
I would ask @jcantero to confirm whether the new enumeration will cause in issues with the existing implementations.
Cheers,
Jason
- Last reply by Samuel Van Stroud
-
This merge request affects 3 packages:
- PhysicsAnalysis/AnalysisCommon/ParticleJetTools
- PhysicsAnalysis/DerivationFramework/DerivationFrameworkJetEtMiss
- Reconstruction/Jet/JetRecConfig
Affected files list will not be printed in this case
Adding @goetz ,@jcatmore ,@calpigia ,@jmellent ,@cantel ,@jveatch ,@nelsonc ,@ispokhar as watchers
- Resolved by Samuel Van Stroud
Hi,
Yes, in general I agree we should use HadronConeExclExtendedTruthLabelID to check number of B-hadrons (C-hadrons) in our top (nB > =1), W (nB = 0) and Zbb,Zcc, Hcc,Hbb categories.
On the other hand, @jveatch , I see that currently the fully contained Zqq definition doesn't include the d12 cuts (L703) to ensure full containment. The corresponding d12 cut should be exactly the same ones applied to Wqq. i.e: isZ = matchZ && jet.m() / 1000. > m_mLowZ && split12Handle(jet) / 1000. > getWZSplit12Cut( jet.pt() / 1000. );
Could this change be implemented?
This would conflict with the current Zbb/Zcc implementation since requiring two B-hadrons already ensures somehow fully containment so the d12 cut is not probably needed.
If the idea is to include new labels (Hbb, Hcc, Zcc and Zbb), I would do it in "R10TruthLabel_R21Precision_2022v1" instead of creating the new "R10TruthLabel_Xbb" or there is any reason to do it separately?.
Thanks.
Regards,
Josu
- Last reply by Samuel Van Stroud
maybe it's a question for @dguest , but I don't think that the HadronCone is usable for largeR jets since the dR might be hardcoded (unless someone reconfigured it). So maybe ghost is safer here?
-
This merge request affects 3 packages:
- PhysicsAnalysis/AnalysisCommon/ParticleJetTools
- PhysicsAnalysis/DerivationFramework/DerivationFrameworkJetEtMiss
- Reconstruction/Jet/JetRecConfig
Affected files list will not be printed in this case
Adding @goetz ,@jcatmore ,@calpigia ,@jmellent ,@cantel ,@jveatch ,@nelsonc ,@ispokhar as watchers
-
Athena AthGeneration AnalysisBase AthAnalysis externals 
cmake make tests 
Full details available on this CI monitor view. Check the JIRA CI status board for known problems
-
This merge request affects 3 packages:
- PhysicsAnalysis/AnalysisCommon/ParticleJetTools
- PhysicsAnalysis/DerivationFramework/DerivationFrameworkJetEtMiss
- Reconstruction/Jet/JetRecConfig
Affected files list will not be printed in this case
Adding @goetz ,@jcatmore ,@calpigia ,@jmellent ,@cantel ,@jveatch ,@nelsonc ,@ispokhar as watchers
-
Athena AthGeneration AnalysisBase AthAnalysis externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
-
Athena AthGeneration AnalysisBase AthAnalysis externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
- Resolved by Samuel Van Stroud
Hello,
I see in the current version that bb and cc categories are included in "isZ" jets. I think considering that now isZ includes d12 cuts, it could be better to include bb and cc categories in "matchedZ" jets to make Zbb and Zcc categories more similar to Hbb and Hcc labels.
Regards,
Josu
- Last reply by Samuel Van Stroud
-
Athena AthGeneration AnalysisBase AthAnalysis externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
- Resolved by Samuel Van Stroud
Please address the outstanding threads and update the description to reflect the new label name.
Jason (now with my L1 hat on)
- Last reply by Samuel Van Stroud
added review-user-action-required label and removed review-pending-level-1 label
-
This merge request affects 3 packages:
- PhysicsAnalysis/AnalysisCommon/ParticleJetTools
- PhysicsAnalysis/DerivationFramework/DerivationFrameworkJetEtMiss
- Reconstruction/Jet/JetRecConfig
Affected files list will not be printed in this case
Adding @goetz ,@jcatmore ,@calpigia ,@jmellent ,@cantel ,@jveatch ,@nelsonc ,@ispokhar as watchers
added review-pending-level-1 label and removed review-user-action-required label
-
Athena AthGeneration AnalysisBase AthAnalysis externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
-
This merge request affects 3 packages:
- PhysicsAnalysis/AnalysisCommon/ParticleJetTools
- PhysicsAnalysis/DerivationFramework/DerivationFrameworkJetEtMiss
- Reconstruction/Jet/JetRecConfig
Affected files list will not be printed in this case
Adding @goetz ,@jcatmore ,@calpigia ,@jmellent ,@cantel ,@jveatch ,@nelsonc ,@ispokhar as watchers
-
This merge request affects 3 packages:
- PhysicsAnalysis/AnalysisCommon/ParticleJetTools
- PhysicsAnalysis/DerivationFramework/DerivationFrameworkJetEtMiss
- Reconstruction/Jet/JetRecConfig
Affected files list will not be printed in this case
Adding @goetz ,@jcatmore ,@calpigia ,@jmellent ,@cantel ,@jveatch ,@nelsonc ,@ispokhar as watchers
-
Athena AthGeneration AnalysisBase AthAnalysis externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
-
Athena AthGeneration AnalysisBase AthAnalysis externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
-
This merge request affects 3 packages:
- PhysicsAnalysis/AnalysisCommon/ParticleJetTools
- PhysicsAnalysis/DerivationFramework/DerivationFrameworkJetEtMiss
- Reconstruction/Jet/JetRecConfig
Affected files list will not be printed in this case
Adding @goetz ,@jcatmore ,@calpigia ,@jmellent ,@cantel ,@jveatch ,@nelsonc ,@ispokhar as watchers
-
Athena AthGeneration AnalysisBase AthAnalysis externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
added review-approved label and removed review-pending-level-1 label
added analysis-review-approved label and removed analysis-review-required label
