Skip to content
Snippets Groups Projects

TrkSurfaces: Move large inline methods from the icc to the .cxx

Merged TrkSurfaces: Move large inline methods from the icc to the .cxx
ATLAS-EGamma/athena:TrkSurface_noInline_large_methods into master
Merged Christos Anastopoulos requested to merge ATLAS-EGamma/athena:TrkSurface_noInline_large_methods into master

TrkSurfaces: Move large inline methods from the icc to the .cxx.

Basically "hide" them for now while trying to follow a bit our guidelines (on inline large methods in the headers) here .

Edited by Christos Anastopoulos

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • Tracking/TrkDetDescr/TrkSurfaces

    This merge request affects 16 files:

    • Tracking/TrkDetDescr/TrkSurfaces/TrkSurfaces/DiamondBounds.icc
    • Tracking/TrkDetDescr/TrkSurfaces/TrkSurfaces/DiscBounds.icc
    • Tracking/TrkDetDescr/TrkSurfaces/TrkSurfaces/DiscTrapezoidalBounds.icc
    • Tracking/TrkDetDescr/TrkSurfaces/TrkSurfaces/RectangleBounds.icc
    • Tracking/TrkDetDescr/TrkSurfaces/TrkSurfaces/RotatedDiamondBounds.icc
    • Tracking/TrkDetDescr/TrkSurfaces/TrkSurfaces/RotatedTrapezoidBounds.icc
    • Tracking/TrkDetDescr/TrkSurfaces/TrkSurfaces/TrapezoidBounds.icc
    • Tracking/TrkDetDescr/TrkSurfaces/TrkSurfaces/TriangleBounds.icc
    • Tracking/TrkDetDescr/TrkSurfaces/src/DiamondBounds.cxx
    • Tracking/TrkDetDescr/TrkSurfaces/src/DiscBounds.cxx
    • Tracking/TrkDetDescr/TrkSurfaces/src/DiscTrapezoidalBounds.cxx
    • Tracking/TrkDetDescr/TrkSurfaces/src/RectangleBounds.cxx
    • Tracking/TrkDetDescr/TrkSurfaces/src/RotatedDiamondBounds.cxx
    • Tracking/TrkDetDescr/TrkSurfaces/src/RotatedTrapezoidBounds.cxx
    • Tracking/TrkDetDescr/TrkSurfaces/src/TrapezoidBounds.cxx
    • Tracking/TrkDetDescr/TrkSurfaces/src/TriangleBounds.cxx

    Adding @amorley as watcher

  • ATLAS Robot added Tracking master review-pending-level-1 labels

    added Tracking master review-pending-level-1 labels

  • Christos Anastopoulos changed the description

    changed the description

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :pencil: :scissors: CI integration tests for projects AthSimulation are cancelled because of compilation error(s)

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :x: CI Result FAILURE (hash f603c442)

    Athena AthSimulation AthGeneration
    externals :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :o: :white_check_mark:
    tests :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :o: AthSimulation: number of compilation errors 3, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 62441]

  • Christos Anastopoulos added full-build label

    added full-build label

  • Christos Anastopoulos
    Christos Anastopoulos @christos ·
    Author Developer

    Jenkins please retry a build

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :pencil: :pushpin: build area is cleaned as MR is labeled as full-build

  • Christos Anastopoulos removed full-build label

    removed full-build label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • Tracking/TrkDetDescr/TrkSurfaces

    This merge request affects 16 files:

    • Tracking/TrkDetDescr/TrkSurfaces/TrkSurfaces/DiamondBounds.icc
    • Tracking/TrkDetDescr/TrkSurfaces/TrkSurfaces/DiscBounds.icc
    • Tracking/TrkDetDescr/TrkSurfaces/TrkSurfaces/DiscTrapezoidalBounds.icc
    • Tracking/TrkDetDescr/TrkSurfaces/TrkSurfaces/RectangleBounds.icc
    • Tracking/TrkDetDescr/TrkSurfaces/TrkSurfaces/RotatedDiamondBounds.icc
    • Tracking/TrkDetDescr/TrkSurfaces/TrkSurfaces/RotatedTrapezoidBounds.icc
    • Tracking/TrkDetDescr/TrkSurfaces/TrkSurfaces/TrapezoidBounds.icc
    • Tracking/TrkDetDescr/TrkSurfaces/TrkSurfaces/TriangleBounds.icc
    • Tracking/TrkDetDescr/TrkSurfaces/src/DiamondBounds.cxx
    • Tracking/TrkDetDescr/TrkSurfaces/src/DiscBounds.cxx
    • Tracking/TrkDetDescr/TrkSurfaces/src/DiscTrapezoidalBounds.cxx
    • Tracking/TrkDetDescr/TrkSurfaces/src/RectangleBounds.cxx
    • Tracking/TrkDetDescr/TrkSurfaces/src/RotatedDiamondBounds.cxx
    • Tracking/TrkDetDescr/TrkSurfaces/src/RotatedTrapezoidBounds.cxx
    • Tracking/TrkDetDescr/TrkSurfaces/src/TrapezoidBounds.cxx
    • Tracking/TrkDetDescr/TrkSurfaces/src/TriangleBounds.cxx

    Adding @amorley as watcher

  • ATLAS Robot added full-build label

    added full-build label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :x: CI Result FAILURE

    Athena AthSimulation AthGeneration
    externals :o: :white_check_mark: :white_check_mark:
    cmake N/A N/A N/A
    make N/A N/A N/A
    tests N/A N/A N/A

    :exclamation: Due to problems in externals build or cmake configuration the job is stopped, results are not available on the ATLAS CI monitor
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 62443]

  • K
    Kacper Wojciech Topolnicki @ktopolni ·
    Developer

    Jenkins please retry a build

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :pencil: Build area was cleaned as per request posted in the DB. The full software build will be performed

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :pencil: :pushpin: build area is cleaned as MR is labeled as full-build

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • Tracking/TrkDetDescr/TrkSurfaces

    This merge request affects 16 files:

    • Tracking/TrkDetDescr/TrkSurfaces/TrkSurfaces/DiamondBounds.icc
    • Tracking/TrkDetDescr/TrkSurfaces/TrkSurfaces/DiscBounds.icc
    • Tracking/TrkDetDescr/TrkSurfaces/TrkSurfaces/DiscTrapezoidalBounds.icc
    • Tracking/TrkDetDescr/TrkSurfaces/TrkSurfaces/RectangleBounds.icc
    • Tracking/TrkDetDescr/TrkSurfaces/TrkSurfaces/RotatedDiamondBounds.icc
    • Tracking/TrkDetDescr/TrkSurfaces/TrkSurfaces/RotatedTrapezoidBounds.icc
    • Tracking/TrkDetDescr/TrkSurfaces/TrkSurfaces/TrapezoidBounds.icc
    • Tracking/TrkDetDescr/TrkSurfaces/TrkSurfaces/TriangleBounds.icc
    • Tracking/TrkDetDescr/TrkSurfaces/src/DiamondBounds.cxx
    • Tracking/TrkDetDescr/TrkSurfaces/src/DiscBounds.cxx
    • Tracking/TrkDetDescr/TrkSurfaces/src/DiscTrapezoidalBounds.cxx
    • Tracking/TrkDetDescr/TrkSurfaces/src/RectangleBounds.cxx
    • Tracking/TrkDetDescr/TrkSurfaces/src/RotatedDiamondBounds.cxx
    • Tracking/TrkDetDescr/TrkSurfaces/src/RotatedTrapezoidBounds.cxx
    • Tracking/TrkDetDescr/TrkSurfaces/src/TrapezoidBounds.cxx
    • Tracking/TrkDetDescr/TrkSurfaces/src/TriangleBounds.cxx

    Adding @amorley as watcher

  • Christos Anastopoulos removed full-build label

    removed full-build label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash f603c442)

    Athena AthSimulation AthGeneration
    externals :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 62454]

  • Christos Anastopoulos changed the description

    changed the description

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply