Make CaloRec a pure component library

This MR moves all classes that are supposed to be linked against from CaloRec into CaloUtils. Only 3 out of the 50 classes defined in CaloRec fall in this category. With this change, CaloRec can be a component-only library.

Next step would be to move all components of CaloUtils to either CaloRec or CaloClusterCorrection, so CaloUtils would become a pure shared library.

Benefits:

• About 10 MByte less installed libraries
• More logical code organisation

I would like to hear @ssnyder's opinion before this MR gets accepted, in particular related to his comment in CaloCellContainerFromClusterTool_test

added 1 commit

• 023a565f - one more cmake fix

Compare with previous version

added 1 commit

• 8f3d4bd3 - CaloRec: Don't link against obsolete LArToolsLib

Compare with previous version

added 270 commits

• 8f3d4bd3...0b4e418f - 269 commits from branch atlas:master
• bf7d5beb - Merge remote-tracking branch 'upstream/master' into CaloRecCompOnly

Compare with previous version

Jenkins please retry a build

This merge request affects 14 packages:

• Calorimeter/CaloCalibHitRec
• Calorimeter/CaloClusterCorrection
• Calorimeter/CaloRec
• Calorimeter/CaloRecGPU
• Calorimeter/CaloTrackUtils
• Calorimeter/CaloUtils
• LArCalorimeter/LArClusterRec
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkCalo
• Reconstruction/HeavyIonRec/HIJetRec
• Reconstruction/RecoTools/IsolationTool
• Reconstruction/eflowRec
• Reconstruction/egamma/egammaTools
• TestBeam/TBRec
• Trigger/TrigAlgorithms/TrigCaloRec

Affected files list will not be printed in this case

Adding @goetz ,@jcatmore ,@calpigia ,@mhodgkin ,@pavol ,@damazio ,@joheinri ,@cantel as watchers

added Calorimeter Derivation Egamma JetEtmiss LAr Reconstruction TestBeam Trigger analysis-review-required master labels

CI Result FAILURE (hash bf7d5beb)

	Athena	AnalysisBase
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 62659]

Thanks Walter. I tried running the tests in the dbg build again with that hack removed, and i do not any more reproduce the ubsan warnings. So i hope that that linking hack is no longer needed and you can remove it.

Jenkins please retry a build

This merge request affects 14 packages:

• Calorimeter/CaloCalibHitRec
• Calorimeter/CaloClusterCorrection
• Calorimeter/CaloRec
• Calorimeter/CaloRecGPU
• Calorimeter/CaloTrackUtils
• Calorimeter/CaloUtils
• LArCalorimeter/LArClusterRec
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkCalo
• Reconstruction/HeavyIonRec/HIJetRec
• Reconstruction/RecoTools/IsolationTool
• Reconstruction/eflowRec
• Reconstruction/egamma/egammaTools
• TestBeam/TBRec
• Trigger/TrigAlgorithms/TrigCaloRec

Affected files list will not be printed in this case

Adding @goetz ,@jcatmore ,@calpigia ,@mhodgkin ,@pavol ,@damazio ,@joheinri ,@cantel as watchers

CI Result SUCCESS (hash bf7d5beb)

	Athena	AnalysisBase
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 62730]

marked this merge request as ready

Looks OK from AR viewpoint, approving

Giovanni (AR)

removed analysis-review-required label

added analysis-review-approved label

added review-pending-level-1 label

Looks good. Approved

Sergei L1

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 4670a092

added sweep:ignore label