Quirks: thread-checker fixes

• remove unnecessary const and casts
• avoid statics
• mark some unavoidable const cast as safe

cc @jchapman @christos

Build area was cleaned as per request posted in the DB. The full software build will be performed

This merge request affects 1 package:

• Simulation/G4Extensions/Quirks

This merge request affects 8 files:

• Simulation/G4Extensions/Quirks/ATLAS_CHECK_THREAD_SAFETY
• Simulation/G4Extensions/Quirks/src/DebugSteppingAction.cxx
• Simulation/G4Extensions/Quirks/src/DummyEquation.cxx
• Simulation/G4Extensions/Quirks/src/DummyEquation.h
• Simulation/G4Extensions/Quirks/src/InfracolorForce.h
• Simulation/G4Extensions/Quirks/src/Quirk.h
• Simulation/G4Extensions/Quirks/src/QuirkTransportation.cxx
• Simulation/G4Extensions/Quirks/src/QuirkWatcher.cxx

Adding @jchapman as watcher

added Simulation master review-pending-level-1 labels

added 1 commit

• 0d2528c7 - Quirks: thread-checker fixes

Compare with previous version

This merge request affects 1 package:

• Simulation/G4Extensions/Quirks

This merge request affects 9 files:

• Simulation/G4Extensions/Quirks/ATLAS_CHECK_THREAD_SAFETY
• Simulation/G4Extensions/Quirks/CMakeLists.txt
• Simulation/G4Extensions/Quirks/src/DebugSteppingAction.cxx
• Simulation/G4Extensions/Quirks/src/DummyEquation.cxx
• Simulation/G4Extensions/Quirks/src/DummyEquation.h
• Simulation/G4Extensions/Quirks/src/InfracolorForce.h
• Simulation/G4Extensions/Quirks/src/Quirk.h
• Simulation/G4Extensions/Quirks/src/QuirkTransportation.cxx
• Simulation/G4Extensions/Quirks/src/QuirkWatcher.cxx

Adding @jchapman as watcher

CI Result SUCCESS (hash 16fb59b3)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 62467]

CI Result SUCCESS (hash 0d2528c7)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 62474]

removed review-pending-level-1 label

added review-pending-level-2 label

Looks ok but there were many changes (including memory management) so asking L2 to double check

Cheers,

L1

Looks good. Karolos (L2)

added review-approved label and removed review-pending-level-2 label

merged

mentioned in commit 9c7c3410

added sweep:ignore label