LArROD: switched to reading CaloSuperCellDetDescrManager from Cond Store

Several clients in the LArROD package switched to reading CaloSuperCellDetDescrManager from Cond Store. This is a part of the ongoing migration of all clients of Calo DD managers.

Build area was cleaned as per request posted in the DB. The full software build will be performed

This merge request affects 1 package:

• LArCalorimeter/LArROD

This merge request affects 6 files:

• LArCalorimeter/LArROD/src/LArNNRawChannelBuilder.cxx
• LArCalorimeter/LArROD/src/LArNNRawChannelBuilder.h
• LArCalorimeter/LArROD/src/LArRawChannelBuilderSCAlg.cxx
• LArCalorimeter/LArROD/src/LArRawChannelBuilderSCAlg.h
• LArCalorimeter/LArROD/src/LArSCSimpleMaker.cxx
• LArCalorimeter/LArROD/src/LArSCSimpleMaker.h

Adding @bcarlson ,@joheinri ,@pavol ,@damazio as watchers

added JetEtmiss LAr master review-pending-level-1 labels

CI Result FAILURE (hash d5149a71)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 62535]

INFO       LArSuperCellBui...  FATAL  Standard std::exception is caught
INFO       LArSuperCellBui...  ERROR SG::ExcNoCondCont: Can't retrieve CondCont from ReadCondHandle for key ConditionStore+CaloSuperCellDetDescrManager. Can't retrieve.
INFO       AthAlgSeq           FATAL  Standard std::exception is caught
INFO       AthAlgSeq           ERROR SG::ExcNoCondCont: Can't retrieve CondCont from ReadCondHandle for key ConditionStore+CaloSuperCellDetDescrManager. Can't retrieve.
INFO       AthAllAlgSeq        FATAL  Standard std::exception is caught
INFO       AthAllAlgSeq        ERROR SG::ExcNoCondCont: Can't retrieve CondCont from ReadCondHandle for key ConditionStore+CaloSuperCellDetDescrManager. Can't retrieve.
INFO       AthAlgEvtSeq        FATAL  Standard std::exception is caught
INFO       AthAlgEvtSeq        ERROR SG::ExcNoCondCont: Can't retrieve CondCont from ReadCondHandle for key ConditionStore+CaloSuperCellDetDescrManager. Can't retrieve.
INFO       AthMasterSeq        FATAL  Standard std::exception is caught
INFO       AthMasterSeq        ERROR SG::ExcNoCondCont: Can't retrieve CondCont from ReadCondHandle for key ConditionStore+CaloSuperCellDetDescrManager. Can't retrieve.
ERROR    Overlay validation test step failed

removed review-pending-level-1 label

added review-user-action-required label

Hi @tadej, the OverlayRun3MC_CAConfig fails here because the CaloSuperCellAlignCondAlg is explicitly disabled in Overlay jobs. OTOH, I see LArSuperCellBuilderAlg involved in this job, so logically one would also enable the CaloSuperCellAlignCondAlg, no?

I remember we have had a few iterations on defining conditions for enabling CaloSuperCellAlignCondAlg in the job, but I don't really remember why it was eventually disabled in Overlay. Any ideas?

P.S. After removing the configFlags.Common.ProductionStep != ProductionStep.Overlay condition the failed test ran successfully to completion.

resolved all threads

added 188 commits

• d5149a71...f1dfcaf1 - 187 commits from branch atlas:master
• 14909058 - LArROD: switched to reading CaloSuperCellDetDescrManager from Cond Store

Compare with previous version

Build area was cleaned as per request posted in the DB. The full software build will be performed

This merge request affects 2 packages:

• LArCalorimeter/LArGeoModel/LArGeoAlgsNV
• LArCalorimeter/LArROD

Affected files list will not be printed in this case

Adding @bcarlson ,@joheinri ,@pavol ,@damazio as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result SUCCESS (hash 14909058)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 62768]

L1-approved.

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit d87396fb

added sweep:ignore label