Fix MuonCaloTagAlg tool config

Trying to fix ATLASRECTS-7384. Not sure why it did not work before, but it was anyways a bit messy. Maybe the public tool needs to be added before adding to the fragment?

Note that ToolHandleArray still behaves strangely. It looks private but it requires a public tool. @wlampl, @fwinkl, @leggett, @jchapman any idea?

Do we ever even need an array here?

Tagging also @jojungge, @emoyse, @tsulaia

Reconstruction/MuonIdentification/MuonCombinedConfig/python/MuonCombinedReconstructionConfig.py

@@ -6,18 +6,17 @@ from AthenaConfiguration.Enums import BeamType
 
 
 def MuonCaloTagAlgCfg(flags, name="MuonCaloTagAlg", **kwargs):
+    result = ComponentAccumulator()
     from MuonCombinedConfig.MuonCombinedRecToolsConfig import MuonCaloTagToolCfg
-    tools = []
-    result = MuonCaloTagToolCfg(flags)
-    tools.append(result.popPrivateTools())
-    kwargs.setdefault("MuonCombinedInDetExtensionTools", tools)
-    result.addPublicTool(kwargs['MuonCombinedInDetExtensionTools'][0])  # Ugh
+    tool = result.popToolsAndMerge(MuonCaloTagToolCfg(flags))
+    # needs to be made public for some reason?
+    result.addPublicTool(tool)
+    kwargs.setdefault("MuonCombinedInDetExtensionTools", [tool])
     kwargs.setdefault("TagMap", "caloTagMap")
     kwargs.setdefault("CombinedTrackCollection", "")
     kwargs.setdefault("METrackCollection", "")
     kwargs.setdefault("usePRDs", False)
-    alg = CompFactory.MuonCombinedInDetExtensionAlg(name, **kwargs)
-    result.addEventAlgo(alg, primary=True)
+    result.addEventAlgo(CompFactory.MuonCombinedInDetExtensionAlg(name, **kwargs))
     return result