Use prefix increment operator as suggested by cppcheck

Use prefix increment operator as suggested by cppcheck

This merge request affects 18 packages:

• HighGranularityTimingDetector/HGTD_Digitization/HGTD_Digitization
• InnerDetector/InDetRecTools/InDetVKalVxInJetTool
• MuonSpectrometer/MuonDetDescr/MuonRegionSelector
• MuonSpectrometer/MuonReconstruction/MuonRIO_OnTrackCreators/MdtDriftCircleOnTrackCreator
• MuonSpectrometer/MuonValidation/MuonDQA/MuonDQAUtils
• MuonSpectrometer/MuonValidation/MuonDQA/MuonRawDataMonitoring/MdtRawDataMonitoring
• PhysicsAnalysis/JetTagging/JetTagMonitoring
• PhysicsAnalysis/JetTagging/JetTagTools
• PhysicsAnalysis/SUSYPhys/LongLivedParticleDPDMaker
• PhysicsAnalysis/SUSYPhys/SUSYTools
• Reconstruction/HeavyIonRec/HIJetRec
• Simulation/Tools/CaloSamplingFractionAnalysis
• Tracking/Acts/ActsTrkAlgs/ActsTrkFittingAlgs
• Tracking/Acts/ActsTrkTools/ActsTrkPriVtxFinderTool
• Tracking/TrkEventCnv/TrkJiveXML
• Tracking/TrkEventCnv/TrkTruthTPCnv
• Tracking/TrkFitter/TrkRefitAlg
• graphics/GeometryJiveXML

Affected files list will not be printed in this case

Adding @jchapman ,@sutt ,@rosati ,@dshope ,@duperrin ,@cmerlass ,@cohm ,@stavrop ,@aroepe ,@jojungge ,@hoide ,@janders ,@tbold ,@toyamaza ,@cvarni ,@salderwe ,@emily ,@goetz ,@amorley ,@wleight ,@zmarshal ,@sroe ,@szambito ,@pagessin ,@mrimoldi ,@apsallid ,@pscholer ,@jmontejo ,@lshan ,@leejr ,@rbianchi as watchers

added ACTS Analysis BTagging DQ Digitization EventDisplay HGTD InnerDetector JetEtmiss MuonSpectrometer Reconstruction SUSYTools Simulation Tau Tracking Trigger analysis-review-required master review-pending-level-1 labels

CI Result FAILURE (hash f5164a68)

	Athena	AnalysisBase
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 62549]

Error detected needs to be fixed:

noerror.sh> ERROR: Found the following errors in RecoRun2MC_CAConfig.log: INFO ToolSvc 0 0 ERROR retrieve(): No Tool Type/Name given

INFO MuonCaloTagAlg 0 0 FATAL Exception with tag=PrivateTool retrieve is caught

INFO MuonCaloTagAlg 0 0 ERROR PrivateTool retrieve Failed to retrieve PrivateTool: StatusCode=FAILURE

removed review-pending-level-1 label

added review-user-action-required label

added 7 commits

• f5164a68...0b4e418f - 6 commits from branch atlas:master
• 12586dfa - Merge remote-tracking branch 'upstream/master' into prefixoperator

Compare with previous version

Hi @weiy ,

I'm sure that is not related. I will try to rerun the CI.

Andrii

Build area was cleaned as per request posted in the DB. The full software build will be performed

This merge request affects 18 packages:

• HighGranularityTimingDetector/HGTD_Digitization/HGTD_Digitization
• InnerDetector/InDetRecTools/InDetVKalVxInJetTool
• MuonSpectrometer/MuonDetDescr/MuonRegionSelector
• MuonSpectrometer/MuonReconstruction/MuonRIO_OnTrackCreators/MdtDriftCircleOnTrackCreator
• MuonSpectrometer/MuonValidation/MuonDQA/MuonDQAUtils
• MuonSpectrometer/MuonValidation/MuonDQA/MuonRawDataMonitoring/MdtRawDataMonitoring
• PhysicsAnalysis/JetTagging/JetTagMonitoring
• PhysicsAnalysis/JetTagging/JetTagTools
• PhysicsAnalysis/SUSYPhys/LongLivedParticleDPDMaker
• PhysicsAnalysis/SUSYPhys/SUSYTools
• Reconstruction/HeavyIonRec/HIJetRec
• Simulation/Tools/CaloSamplingFractionAnalysis
• Tracking/Acts/ActsTrkAlgs/ActsTrkFittingAlgs
• Tracking/Acts/ActsTrkTools/ActsTrkPriVtxFinderTool
• Tracking/TrkEventCnv/TrkJiveXML
• Tracking/TrkEventCnv/TrkTruthTPCnv
• Tracking/TrkFitter/TrkRefitAlg
• graphics/GeometryJiveXML

Affected files list will not be printed in this case

Adding @jchapman ,@sutt ,@rosati ,@dshope ,@duperrin ,@cmerlass ,@cohm ,@stavrop ,@aroepe ,@jojungge ,@hoide ,@janders ,@tbold ,@toyamaza ,@cvarni ,@salderwe ,@emily ,@goetz ,@amorley ,@wleight ,@zmarshal ,@sroe ,@szambito ,@pagessin ,@mrimoldi ,@apsallid ,@pscholer ,@jmontejo ,@lshan ,@leejr ,@rbianchi as watchers

added review-pending-level-1 label and removed review-user-action-required label

marked this merge request as draft

CI Result FAILURE (hash 12586dfa)

	Athena	AnalysisBase
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 62602]

added 94 commits

• 12586dfa...f1dfcaf1 - 93 commits from branch atlas:master
• 5817de6e - Merge remote-tracking branch 'upstream/master' into prefixoperator

Compare with previous version

resolved all threads

marked this merge request as ready

Build area was cleaned as per request posted in the DB. The full software build will be performed

This merge request affects 17 packages:

• HighGranularityTimingDetector/HGTD_Digitization/HGTD_Digitization
• InnerDetector/InDetRecTools/InDetVKalVxInJetTool
• MuonSpectrometer/MuonDetDescr/MuonRegionSelector
• MuonSpectrometer/MuonReconstruction/MuonRIO_OnTrackCreators/MdtDriftCircleOnTrackCreator
• MuonSpectrometer/MuonValidation/MuonDQA/MuonDQAUtils
• MuonSpectrometer/MuonValidation/MuonDQA/MuonRawDataMonitoring/MdtRawDataMonitoring
• PhysicsAnalysis/JetTagging/JetTagMonitoring
• PhysicsAnalysis/JetTagging/JetTagTools
• PhysicsAnalysis/SUSYPhys/LongLivedParticleDPDMaker
• PhysicsAnalysis/SUSYPhys/SUSYTools
• Reconstruction/HeavyIonRec/HIJetRec
• Tracking/Acts/ActsTrkAlgs/ActsTrkFittingAlgs
• Tracking/Acts/ActsTrkTools/ActsTrkPriVtxFinderTool
• Tracking/TrkEventCnv/TrkJiveXML
• Tracking/TrkEventCnv/TrkTruthTPCnv
• Tracking/TrkFitter/TrkRefitAlg
• graphics/GeometryJiveXML

Affected files list will not be printed in this case

Adding @jchapman ,@sutt ,@rosati ,@dshope ,@duperrin ,@cmerlass ,@cohm ,@stavrop ,@aroepe ,@jojungge ,@hoide ,@janders ,@tbold ,@toyamaza ,@cvarni ,@salderwe ,@emily ,@goetz ,@amorley ,@wleight ,@zmarshal ,@sroe ,@szambito ,@pagessin ,@mrimoldi ,@apsallid ,@pscholer ,@jmontejo ,@lshan ,@leejr ,@rbianchi as watchers

Looks OK from AR viewpoint, approving

Giovanni (AR)

removed analysis-review-required label