DerivationFrameworkBPhys: enable thread-checker

BPhysVertexTrackBase/CfAthAlgTool and derivatives are not thread-safe.

I'm pretty such the intention is for this code to be brought back into use @wwalko ?

Build area was cleaned as per request posted in the DB. The full software build will be performed

This merge request affects 1 package:

• PhysicsAnalysis/DerivationFramework/DerivationFrameworkBPhys

This merge request affects 19 files:

• PhysicsAnalysis/DerivationFramework/DerivationFrameworkBPhys/CMakeLists.txt
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkBPhys/DerivationFrameworkBPhys/ATLAS_CHECK_THREAD_SAFETY
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkBPhys/DerivationFrameworkBPhys/BMuonTrackIsoTool.h
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkBPhys/DerivationFrameworkBPhys/BPhysVarBlinder.h
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkBPhys/DerivationFrameworkBPhys/BPhysVertexTrackBase.h
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkBPhys/DerivationFrameworkBPhys/BVertexClosestTrackTool.h
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkBPhys/DerivationFrameworkBPhys/BVertexTrackIsoTool.h
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkBPhys/DerivationFrameworkBPhys/BmumuThinningTool.h
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkBPhys/DerivationFrameworkBPhys/Bmumu_reco_mumu.h
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkBPhys/DerivationFrameworkBPhys/CfAthAlgTool.h
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkBPhys/DerivationFrameworkBPhys/Select_Bmumu.h
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkBPhys/DerivationFrameworkBPhys/TriggerCountToMetadata.h
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkBPhys/src/BPhysVarBlinder.cxxNoCompile
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkBPhys/src/BmumuThinningTool.cxx_NoCompile
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkBPhys/src/Bmumu_reco_mumu.cxx
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkBPhys/src/CfAthAlgTool.cxx
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkBPhys/src/Select_Bmumu.cxx
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkBPhys/src/TriggerCountToMetadata.cxx
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkBPhys/src/components/DerivationFrameworkBPhys_entries.cxx

Adding @jcatmore ,@calpigia ,@wwalko ,@abarton as watchers

added Derivation Trigger master review-pending-level-1 labels

changed title from DerivationFrameworkBPhys: delete unsued code and thread-checker to DerivationFrameworkBPhys: delete unsued code and enable thread-checker

The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)FullSim.*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

CI Result FAILURE (hash 29d2a6c9)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 62572]

removed review-pending-level-1 label

added review-user-action-required label

added 42 commits

• 29d2a6c9...89f86539 - 41 commits from branch atlas:master
• 687c40ec - DerivationFrameworkBPhys: thread-checker fixes

Compare with previous version

This merge request affects 1 package:

• PhysicsAnalysis/DerivationFramework/DerivationFrameworkBPhys

This merge request affects 10 files:

• PhysicsAnalysis/DerivationFramework/DerivationFrameworkBPhys/CMakeLists.txt
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkBPhys/DerivationFrameworkBPhys/ATLAS_CHECK_THREAD_SAFETY
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkBPhys/DerivationFrameworkBPhys/BMuonTrackIsoTool.h
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkBPhys/DerivationFrameworkBPhys/BPhysVertexTrackBase.h
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkBPhys/DerivationFrameworkBPhys/BVertexClosestTrackTool.h
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkBPhys/DerivationFrameworkBPhys/BVertexTrackIsoTool.h
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkBPhys/DerivationFrameworkBPhys/Bmumu_reco_mumu.h
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkBPhys/DerivationFrameworkBPhys/CfAthAlgTool.h
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkBPhys/DerivationFrameworkBPhys/Select_Bmumu.h
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkBPhys/DerivationFrameworkBPhys/TriggerCountToMetadata.h

Adding @jcatmore ,@calpigia ,@wwalko ,@abarton as watchers

added review-pending-level-1 label and removed review-user-action-required label

changed title from DerivationFrameworkBPhys: delete unsued code and enable thread-checker to DerivationFrameworkBPhys: enable thread-checker

changed the description

added review-user-action-required label and removed review-pending-level-1 label

resolved all threads

removed review-user-action-required label

added review-pending-level-1 label

The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)FullSim.*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

CI Result FAILURE (hash 687c40ec)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 62683]

Unrelated failures.

lgtm approving -- L1

added review-approved label and removed review-pending-level-1 label

mentioned in commit 9a945ab8

merged

added sweep:ignore label