ExpressionEvaluation: convert macros to functions

Convert the macros in xAODVariableProxyLoaders to functions. This will make it easier to follow this code. This is done by introducing a new base class xAODProxyLoader that holds the helper functions and the accessor cache. Also use std::unique_ptr for the latter.

This is just moving code around. There should be no functional changes.

cc @jcatmore

changed title from Draft: ExpressionEvaluation: thread-checker fixes to Draft: ExpressionEvaluation: convert macros to functions

added 1 commit

• 3c021c8b - ExpressionEvaluation: convert macros to functions

Compare with previous version

added 1 commit

• 362c1444 - ExpressionEvaluation: convert macros to functions

Compare with previous version

added 19 commits

• 362c1444...ebae632e - 18 commits from branch atlas:master
• b9700b8d - ExpressionEvaluation: convert macros to functions

Compare with previous version

marked this merge request as ready

changed the description

This merge request affects 1 package:

• PhysicsAnalysis/CommonTools/ExpressionEvaluation

This merge request affects 2 files:

• PhysicsAnalysis/CommonTools/ExpressionEvaluation/ExpressionEvaluation/xAODVariableProxyLoaders.h
• PhysicsAnalysis/CommonTools/ExpressionEvaluation/Root/xAODVariableProxyLoaders.cxx

added Analysis master review-pending-level-1 labels

The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)AF3.*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

CI Result FAILURE (hash b9700b8d)

	Athena	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 62623]

RROR    RAWtoALL validation test step failed
ERROR    Full RAWtoALL step log:
  19:46:19 ToolSvc                                                0     0   ERROR retrieve(): No Tool Type/Name given
  19:46:19 MuonCaloTagAlg                                         0     0   FATAL  Exception with tag=PrivateTool retrieve is caught
  19:46:19 MuonCaloTagAlg                                         0     0   ERROR PrivateTool retrieve 	 Failed to retrieve PrivateTool: 	 StatusCode=FAILURE
  19:46:20 AlgTask                                                0     0   FATAL .executeEvent(): Exception with tag=PrivateTool retrieve thrown by MuonCaloTagAlg
  19:46:20 AlgTask                                                0     0   ERROR PrivateTool retrieve 	 Failed to retrieve PrivateTool: 	 StatusCode=FAILURE
  19:46:20 AvalancheSchedulerSvc                                  0     0   ERROR *** Stall detected, event context: s: 0  e: 0
  19:46:20 AvalancheSchedulerSvc                                  0     0   ERROR Event 0 on slot 0 failed

obviously unrelated

removed review-pending-level-1 label

added review-approved label

mentioned in commit 4d4ffa0c

merged

added sweep:ignore label