Fix cppcheck warnings in CaloSamplingFraction package
Switch CaloSamplingFractionAnalysis code to use range-based for loops to fix cppcheck warnings. (I am aware that this code should be updated to use Read/WriteHandles, but that is best dealt with in a separate MR.)
Due to the way the root script is called it does not make sense to switch to passing the arguments by const reference, so I have suppressed those warnings.
Tagging @sroe.