InDetConfig:Add missing configuration of TrackParticleCreatorTool to InDetTrackSelectorToolCfg

I believe this is the fix for ATLASRECTS-7384

I'm still running tests locally but I wanted to open this now, since this is urgent.

cc @fwinkl @tsulaia

added bugfix urgent labels

This merge request affects 1 package:

• InnerDetector/InDetConfig

This merge request affects 1 file:

• InnerDetector/InDetConfig/python/InDetTrackSelectorToolConfig.py

Adding @goetz ,@sroe as watchers

added InnerDetector master review-pending-level-1 labels

mentioned in merge request !58837 (merged)

Hi @tstreble - on reflection I'm a little worried. If the default behaviour should be that m_particleCreator is not used in these workflows, then the changes in this MR are incorrect and I should close it in favour of !58837 (merged) shouldn't I?

Basically by setting it to something valid, I am potentially changing the output?

In theory, you are right.

In practice, this is not very relevant, because in the default config, with m_useSharedHitInfo=false, m_partCreatorToolAvailable will anyway be set to false after !58837 (merged), so setting the tool doesn't make any difference. Even without !58837 (merged), the tool will simply run to create a TrackParticle but then it's only used if m_useSharedHitInfo=true https://gitlab.cern.ch/atlas/athena/-/blob/master/InnerDetector/InDetRecTools/InDetTrackSelectorTool/src/InDetDetailedTrackSelectorTool.cxx#L1116 It's a bit of extra CPU as long as !58837 (merged) is not merged, but it fixes the issue in ATLASRECTS-7384.

Your change avoids the need to explicitly set the TrackParticleCreatorTool for configs with useSharedHitInfo=true, which don't exist yet as far as I can see.

This being said, since I see now, that many tests are failing here (not clear if it's related), we can potentially close this one in favour of !58837 (merged).

added Run2-DataReco-output-changed Run3-DataReco-output-changed labels

CI Result FAILURE (hash bd2f9210)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 62705]

Quite a few crashes in CI. Back to you @emoyse

added review-user-action-required label

Not sure how this can be related:

16:46:44 Py:conf2toConfigurable    INFO   Could not set attribute. Type of conf1 <class 'PixelConditionsAlgorithms.PixelConditionsAlgorithmsConf.PixeldEdxAlg'>.
  16:46:44 Shortened traceback (most recent user call last):
  16:46:44   File "/build2/ci-builds/master/Athena/build/Athena/x86_64-centos7-gcc11-opt/jobOptions/RecJobTransforms/skeleton.RAWtoALL_tf.py", line 188, in <module>
  16:46:44     include( "RecExCommon/RecExCommon_topOptions.py" )
  16:46:44   File "/build2/ci-builds/master/Athena/build/Athena/x86_64-centos7-gcc11-opt/jobOptions/RecExCommon/RecExCommon_topOptions.py", line 513, in <module>
  16:46:44     include ("RecExCommon/CombinedRec_config.py")
  16:46:44   File "/build2/ci-builds/master/Athena/build/Athena/x86_64-centos7-gcc11-opt/jobOptions/RecExCommon/CombinedRec_config.py", line 151, in <module>
  16:46:44     CAtoGlobalWrapper(BTagRecoSplitCfg, ConfigFlags)
  16:46:44   File "/build2/ci-builds/master/Athena/build/Athena/x86_64-centos7-gcc11-opt/python/AthenaConfiguration/LegacySupport.py", line 379, in CAtoGlobalWrapper
  16:46:44     appendCAtoAthena(ca)
  16:46:44   File "/build2/ci-builds/master/Athena/build/Athena/x86_64-centos7-gcc11-opt/python/AthenaConfiguration/LegacySupport.py", line 408, in appendCAtoAthena
  16:46:44     instance = conf2toConfigurable( comp, indent="  ", servicesOfThisCA=servicesOfThisCA )
  16:46:44   File "/build2/ci-builds/master/Athena/build/Athena/x86_64-centos7-gcc11-opt/python/AthenaConfiguration/LegacySupport.py", line 348, in conf2toConfigurable
  16:46:44     _areSettingsSame( existingConfigurable, comp, indent,  servicesOfThisCA )
  16:46:44   File "/build2/ci-builds/master/Athena/build/Athena/x86_64-centos7-gcc11-opt/python/AthenaConfiguration/LegacySupport.py", line 290, in _areSettingsSame
  16:46:44     setattr(conf1, pname, pvalue)
  16:46:44
  16:46:44 AttributeError: 'PixeldEdxAlg' object attribute 'ReadFromCOOL' is read-only

Jenkins please retry a build

Build area was cleaned as per request posted in the DB. The full software build will be performed

This merge request affects 1 package:

• InnerDetector/InDetConfig

This merge request affects 1 file:

• InnerDetector/InDetConfig/python/InDetTrackSelectorToolConfig.py

Adding @goetz ,@sroe as watchers

removed review-user-action-required label

removed urgent label

removed Run2-DataReco-output-changed label

removed Run3-DataReco-output-changed label

Just FYI I will probably close this, but I'm curious about the errors above.

added Run2-DataReco-output-changed Run3-DataReco-output-changed labels

CI Result FAILURE (hash bd2f9210)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 62762]