Skip to content
Snippets Groups Projects

ExpressionEvaluation: use ConcurrentStrMap for caches

Merged ExpressionEvaluation: use ConcurrentStrMap for caches
fwinkl/athena:expreval5 into master
Merged Frank Winklmeier requested to merge fwinkl/athena:expreval5 into master

Use thread-safe ConncurrentStrMap for accessor and proxy caches. Also make variableTypeFromString const.

Closes ATLASRECTS-7369.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Frank Winklmeier
    Frank Winklmeier @fwinkl ·
    Author Maintainer

    cc @ssnyder for the use of ConcurrentStrMap.

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :pencil: Build area was cleaned as per request posted in the DB. The full software build will be performed

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • PhysicsAnalysis/CommonTools/ExpressionEvaluation

    This merge request affects 14 files:

    • PhysicsAnalysis/CommonTools/ExpressionEvaluation/ExpressionEvaluation/ATLAS_CHECK_THREAD_SAFETY
    • PhysicsAnalysis/CommonTools/ExpressionEvaluation/ExpressionEvaluation/IProxyLoader.h
    • PhysicsAnalysis/CommonTools/ExpressionEvaluation/ExpressionEvaluation/MultipleProxyLoader.h
    • PhysicsAnalysis/CommonTools/ExpressionEvaluation/ExpressionEvaluation/SGNTUPProxyLoader.h
    • PhysicsAnalysis/CommonTools/ExpressionEvaluation/ExpressionEvaluation/SGxAODProxyLoader.h
    • PhysicsAnalysis/CommonTools/ExpressionEvaluation/ExpressionEvaluation/TestProxyLoader.h
    • PhysicsAnalysis/CommonTools/ExpressionEvaluation/ExpressionEvaluation/TriggerDecisionProxyLoader.h
    • PhysicsAnalysis/CommonTools/ExpressionEvaluation/ExpressionEvaluation/xAODVariableProxyLoaders.h
    • PhysicsAnalysis/CommonTools/ExpressionEvaluation/Root/MultipleProxyLoader.cxx
    • PhysicsAnalysis/CommonTools/ExpressionEvaluation/Root/TestProxyLoader.cxx
    • PhysicsAnalysis/CommonTools/ExpressionEvaluation/Root/xAODVariableProxyLoaders.cxx
    • PhysicsAnalysis/CommonTools/ExpressionEvaluation/src/SGNTUPProxyLoader.cxx
    • PhysicsAnalysis/CommonTools/ExpressionEvaluation/src/SGxAODProxyLoader.cxx
    • PhysicsAnalysis/CommonTools/ExpressionEvaluation/src/TriggerDecisionProxyLoader.cxx
  • ATLAS Robot added Analysis Trigger master review-pending-level-1 labels

    added Analysis Trigger master review-pending-level-1 labels

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :pencil: :scissors: The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)FullSim.*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

  • Frank Winklmeier
    Frank Winklmeier @fwinkl ·
    Author Maintainer

    Jenkins please retry a build

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :pencil: Build area was cleaned as per request posted in the DB. The full software build will be performed

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • PhysicsAnalysis/CommonTools/ExpressionEvaluation

    This merge request affects 14 files:

    • PhysicsAnalysis/CommonTools/ExpressionEvaluation/ExpressionEvaluation/ATLAS_CHECK_THREAD_SAFETY
    • PhysicsAnalysis/CommonTools/ExpressionEvaluation/ExpressionEvaluation/IProxyLoader.h
    • PhysicsAnalysis/CommonTools/ExpressionEvaluation/ExpressionEvaluation/MultipleProxyLoader.h
    • PhysicsAnalysis/CommonTools/ExpressionEvaluation/ExpressionEvaluation/SGNTUPProxyLoader.h
    • PhysicsAnalysis/CommonTools/ExpressionEvaluation/ExpressionEvaluation/SGxAODProxyLoader.h
    • PhysicsAnalysis/CommonTools/ExpressionEvaluation/ExpressionEvaluation/TestProxyLoader.h
    • PhysicsAnalysis/CommonTools/ExpressionEvaluation/ExpressionEvaluation/TriggerDecisionProxyLoader.h
    • PhysicsAnalysis/CommonTools/ExpressionEvaluation/ExpressionEvaluation/xAODVariableProxyLoaders.h
    • PhysicsAnalysis/CommonTools/ExpressionEvaluation/Root/MultipleProxyLoader.cxx
    • PhysicsAnalysis/CommonTools/ExpressionEvaluation/Root/TestProxyLoader.cxx
    • PhysicsAnalysis/CommonTools/ExpressionEvaluation/Root/xAODVariableProxyLoaders.cxx
    • PhysicsAnalysis/CommonTools/ExpressionEvaluation/src/SGNTUPProxyLoader.cxx
    • PhysicsAnalysis/CommonTools/ExpressionEvaluation/src/SGxAODProxyLoader.cxx
    • PhysicsAnalysis/CommonTools/ExpressionEvaluation/src/TriggerDecisionProxyLoader.cxx
  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :pencil: :scissors: The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)FullSim.*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash a1c00f1d)

    Athena AthAnalysis
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 62775]

  • Yingjie Wei
    Yingjie Wei @weiy ·
    Developer

    L1-APPROVED

  • Yingjie Wei removed review-pending-level-1 label

    removed review-pending-level-1 label

  • Yingjie Wei added review-approved label

    added review-approved label

  • Vakhtang Tsulaia merged

    merged

  • Vakhtang Tsulaia mentioned in commit 83bf52a4

    mentioned in commit 83bf52a4

  • Atlas Nightlybuild added sweep:ignore label

    added sweep:ignore label

Please register or sign in to reply