Skip to content
Snippets Groups Projects

Update STGC pad trigger decoding to handle null payload

Merged Update STGC pad trigger decoding to handle null payload
(removed):UpdateStgcPadTriggerToHandleNullPayload into master
All threads resolved!
Merged Alexander Naip Tuna requested to merge (removed):UpdateStgcPadTriggerToHandleNullPayload into master
All threads resolved!

A quick update with respect to !58364 (merged)

The STGC pad trigger readout introduced a new type of data packet, in case of emergency, with only null characters in the payload. This update checks for that payload and acts accordingly.

cc @sfrances @vadamico @fgravili

Merge request reports

Approval is optional

Merged by Vakhtang TsulaiaVakhtang Tsulaia 2 years ago (Dec 1, 2022 6:52pm UTC)

Merge details

  • Changes merged into master with 45d86750 (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Alexander Naip Tuna added 1 commit

    added 1 commit

    • ca306aae - Use std alg for compactness and clarity

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :pencil: Build area was cleaned as per request posted in the DB. The full software build will be performed

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • MuonSpectrometer/MuonCnv/MuonNSWCommonDecode

    This merge request affects 2 files:

    • MuonSpectrometer/MuonCnv/MuonNSWCommonDecode/MuonNSWCommonDecode/NSWPadTriggerL1a.h
    • MuonSpectrometer/MuonCnv/MuonNSWCommonDecode/src/NSWPadTriggerL1a.cpp

    Adding @rosati ,@wleight ,@stavrop ,@jojungge ,@apsallid ,@pscholer as watchers

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 180bb42c)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 62787]

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash ca306aae)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 62796]

  • Yingjie Wei
    Yingjie Wei @weiy ·
    Developer

    L1-approved.

  • Yingjie Wei added review-approved label and removed review-pending-level-1 label

    added review-approved label and removed review-pending-level-1 label

  • Johannes Junggeburth resolved all threads

    resolved all threads

  • Vakhtang Tsulaia merged

    merged

  • Vakhtang Tsulaia mentioned in commit 45d86750

    mentioned in commit 45d86750

  • Atlas Nightlybuild added sweep:ignore label

    added sweep:ignore label

  • Julien Maurer added review-approved-tier0 label

    added review-approved-tier0 label

    • Please register or sign in to reply