Make useMuonTopoClusters depend only on ProductionStep enum.
This MR updates the configuration of the pflow muon link algorithm to set the useMuonTopoClusters property based on the value of the CA ProductionSetep enum. Unless this is set to derivation, then we assume CaloCells are accessible and set it to false. Then I removed all usage of useMuonTopoClusters from client configurations. I verified this worked in RecExCommon RAWtoALL and RAWtoESD + ESDtoAOD workflows. I also ran test_trigAna_RDOtoRun3DQ_v1Dev_build.py to verify this workflow is ok (and it is after updating JetEfficiencyMonitoring config to run the global pflow linking). Finally I tested both PHYS and PHSYVal derivations and both example jobs worked fine. So I conclude the auto configuration of this property works well in all relevant production workflows. I also took the opportunity to remove the AODTests property from all PFlow linking configurations. This functionality is not used and the same result is achieved elsewhere via the remapping service.
Merge request reports
Activity
This merge request affects 5 packages:
- Control/AthenaMonitoring
- PhysicsAnalysis/DerivationFramework/DerivationFrameworkPhys
- PhysicsAnalysis/DerivationFramework/DerivationFrameworkPhysicsValidation
- Reconstruction/eflowRec
- Trigger/TrigT1/TrigT1CaloMonitoring
Affected files list will not be printed in this case
Adding @zmarshal ,@goetz ,@dshope ,@duperrin ,@jcatmore ,@calpigia ,@mhodgkin ,@serodrig ,@thompson ,@ssnyder ,@cantel as watchers
added Core DQ Derivation JetEtmiss Reconstruction Trigger master review-pending-level-1 labels
CI Result SUCCESS (hash 882a3824)Athena externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 62804]added review-approved label
removed review-pending-level-1 label
mentioned in commit fe81002f
added sweep:ignore label