JetUtils: Fix cppcheck warnings.

Prefer preincrement to postincrement for iterator classes. Pass strings by const reference rather than by value.

This merge request affects 1 package:

• Reconstruction/Jet/JetUtils

This merge request affects 5 files:

• Reconstruction/Jet/JetUtils/JetUtils/JetCaloCalculations.h
• Reconstruction/Jet/JetUtils/JetUtils/cyl_geom.h
• Reconstruction/Jet/JetUtils/Root/cyl_geom.cxx
• Reconstruction/Jet/JetUtils/src/JetCaloCellQualityUtils.cxx
• Reconstruction/Jet/JetUtils/src/JetCellAccessor.cxx

Adding @goetz as watcher

added JetEtmiss Reconstruction analysis-review-required master review-pending-level-1 labels

Looks OK from AR viewpoint, approving

Giovanni (AR)

removed analysis-review-required label

added analysis-review-approved label

CI Result SUCCESS (hash 7b917ec3)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 62889]

removed review-pending-level-1 label

added review-approved label

merged

mentioned in commit b6ffa71d

added sweep:ignore label