EvtGen_i: thread-checker fixes

Const fixes and mark the non-const access to the factory as not thread-safe.

This merge request affects 1 package:

• Generators/EvtGen_i

This merge request affects 15 files:

• Generators/EvtGen_i/CMakeLists.txt
• Generators/EvtGen_i/EvtGen_i/ATLAS_CHECK_THREAD_SAFETY
• Generators/EvtGen_i/EvtGen_i/EvtGenExternal/EvtExternalGenFactory.hh
• Generators/EvtGen_i/EvtGen_i/EvtGenExternal/EvtExternalGenList.hh
• Generators/EvtGen_i/src/Belle2/EvtB0toKsKK.cc
• Generators/EvtGen_i/src/Belle2/EvtBGL.cc
• Generators/EvtGen_i/src/Belle2/EvtBSemiTauonicScalarMesonAmplitude.cc
• Generators/EvtGen_i/src/Belle2/EvtBSemiTauonicVectorMesonAmplitude.cc
• Generators/EvtGen_i/src/Belle2/EvtHQET3.cc
• Generators/EvtGen_i/src/Belle2/EvtLLSW.cc
• Generators/EvtGen_i/src/Belle2/EvtLLSWFF.cc
• Generators/EvtGen_i/src/Belle2/EvtYmSToYnSpipiCLEOboost.cc
• Generators/EvtGen_i/src/EvtExternalGenFactory.cxx
• Generators/EvtGen_i/src/EvtExternalGenList.cxx
• Generators/EvtGen_i/src/EvtPythia.cxx

added Generators Tau master review-pending-level-1 labels

CI Result FAILURE (hash eeeda11e)

	Athena	AthGeneration
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 62924]

Unrelated EGamma test failures.

Hmm @tadej i guess this is what you meant with accidentally rm the inputs of these ?

Jenkins please retry a build

Build area was cleaned as per request posted in the DB. The full software build will be performed

This merge request affects 1 package:

• Generators/EvtGen_i

This merge request affects 15 files:

• Generators/EvtGen_i/CMakeLists.txt
• Generators/EvtGen_i/EvtGen_i/ATLAS_CHECK_THREAD_SAFETY
• Generators/EvtGen_i/EvtGen_i/EvtGenExternal/EvtExternalGenFactory.hh
• Generators/EvtGen_i/EvtGen_i/EvtGenExternal/EvtExternalGenList.hh
• Generators/EvtGen_i/src/Belle2/EvtB0toKsKK.cc
• Generators/EvtGen_i/src/Belle2/EvtBGL.cc
• Generators/EvtGen_i/src/Belle2/EvtBSemiTauonicScalarMesonAmplitude.cc
• Generators/EvtGen_i/src/Belle2/EvtBSemiTauonicVectorMesonAmplitude.cc
• Generators/EvtGen_i/src/Belle2/EvtHQET3.cc
• Generators/EvtGen_i/src/Belle2/EvtLLSW.cc
• Generators/EvtGen_i/src/Belle2/EvtLLSWFF.cc
• Generators/EvtGen_i/src/Belle2/EvtYmSToYnSpipiCLEOboost.cc
• Generators/EvtGen_i/src/EvtExternalGenFactory.cxx
• Generators/EvtGen_i/src/EvtExternalGenList.cxx
• Generators/EvtGen_i/src/EvtPythia.cxx

removed review-pending-level-1 label

added review-approved label

CI Result SUCCESS (hash eeeda11e)

	Athena	AthGeneration
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 62982]

resolved all threads

mentioned in commit 810003f0

merged

added sweep:ignore label