Skip to content
Snippets Groups Projects

Remove the broken barcode-based filter.

Merged Andrii Verbytskyi requested to merge averbyts/athena:genobjectsfilter into master
All threads resolved!

Remove the broken barcode-based filter. The reasoning: the filter assumes that the cut on barcode is the cut on the number of particles and therefore will not work properly.

Tag @jchapman

Edited by Andrii Verbytskyi

Merge request reports

Pipeline #4853193 passed

Pipeline passed for 884ecbc2 on averbyts:genobjectsfilter

Merged by Tadej NovakTadej Novak 2 years ago (Dec 5, 2022 5:48pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    Compare with previous version

  • Andrii Verbytskyi resolved all threads

    resolved all threads

  • This merge request affects 1 package:

    • PhysicsAnalysis/D3PDMaker/TruthD3PDAnalysis

    This merge request affects 1 file:

    • PhysicsAnalysis/D3PDMaker/TruthD3PDAnalysis/src/GenObjectsFilterTool.cxx
  • :pencil: :scissors: The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)AF3.*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

  • :white_check_mark: CI Result SUCCESS (hash 884ecbc2)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 63064]

  • Approved
    Albert (L1)

  • added review-approved label and removed review-pending-level-1 label

  • merged

  • Tadej Novak mentioned in commit 21867352

    mentioned in commit 21867352

  • Please register or sign in to reply
    Loading