xAODRootAccess: thread-safety fixes

Move towards making xAORRootAccess thread-safe:

• Split the const-violating TVirtualManager::isSet interface into a const isSet and non-const create interface. (cc @akraszna)
• Use ConcurrentStrMap in TStore for cache. (cc @ssnyder)

Relates to ATEAM-863.

This merge request affects 1 package:

• Control/xAODRootAccess

This merge request affects 11 files:

• Control/xAODRootAccess/Root/TAuxBranchManager.cxx
• Control/xAODRootAccess/Root/TAuxManager.cxx
• Control/xAODRootAccess/Root/TEvent.cxx
• Control/xAODRootAccess/Root/TObjectManager.cxx
• Control/xAODRootAccess/Root/TPrimitiveAuxBranchManager.cxx
• Control/xAODRootAccess/Root/TStore.cxx
• Control/xAODRootAccess/xAODRootAccess/tools/TAuxBranchManager.h
• Control/xAODRootAccess/xAODRootAccess/tools/TAuxManager.h
• Control/xAODRootAccess/xAODRootAccess/tools/TObjectManager.h
• Control/xAODRootAccess/xAODRootAccess/tools/TPrimitiveAuxBranchManager.h
• Control/xAODRootAccess/xAODRootAccess/tools/TVirtualManager.h

Adding @akraszna ,@ssnyder as watchers

added Core Tau analysis-review-required master review-pending-level-1 labels

WARNING: big files (>100K) are found in the changeset

140K in file Control/xAODRootAccess/Root/TEvent.cxx

removed Tau label

CI Result FAILURE (hash f73e4605)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 63074]

removed review-pending-level-1 label

added 1 commit

• 27449b31 - xAODRootAccess: split TVirtualManager::isSet interface

Compare with previous version

This merge request affects 1 package:

• Control/xAODRootAccess

This merge request affects 11 files:

• Control/xAODRootAccess/Root/TAuxBranchManager.cxx
• Control/xAODRootAccess/Root/TAuxManager.cxx
• Control/xAODRootAccess/Root/TEvent.cxx
• Control/xAODRootAccess/Root/TObjectManager.cxx
• Control/xAODRootAccess/Root/TPrimitiveAuxBranchManager.cxx
• Control/xAODRootAccess/Root/TStore.cxx
• Control/xAODRootAccess/xAODRootAccess/tools/TAuxBranchManager.h
• Control/xAODRootAccess/xAODRootAccess/tools/TAuxManager.h
• Control/xAODRootAccess/xAODRootAccess/tools/TObjectManager.h
• Control/xAODRootAccess/xAODRootAccess/tools/TPrimitiveAuxBranchManager.h
• Control/xAODRootAccess/xAODRootAccess/tools/TVirtualManager.h

Adding @akraszna ,@ssnyder as watchers

added Tau review-pending-level-1 labels

WARNING: big files (>100K) are found in the changeset

140K in file Control/xAODRootAccess/Root/TEvent.cxx

CI integration tests for projects AnalysisBase are cancelled because of compilation error(s)

CI Result FAILURE (hash 27449b31)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 1, warnings 17
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 63107]

Unrelated link error:

PathResolver.cxx:(.text+0xb5b): undefined reference to `boost::filesystem::path::operator/=(boost::filesystem::path const&)'

waiting for node cleanup.

Jenkins please retry a build

Build area was cleaned as per request posted in the DB. The full software build will be performed

This merge request affects 1 package:

• Control/xAODRootAccess

This merge request affects 11 files:

• Control/xAODRootAccess/Root/TAuxBranchManager.cxx
• Control/xAODRootAccess/Root/TAuxManager.cxx
• Control/xAODRootAccess/Root/TEvent.cxx
• Control/xAODRootAccess/Root/TObjectManager.cxx
• Control/xAODRootAccess/Root/TPrimitiveAuxBranchManager.cxx
• Control/xAODRootAccess/Root/TStore.cxx
• Control/xAODRootAccess/xAODRootAccess/tools/TAuxBranchManager.h
• Control/xAODRootAccess/xAODRootAccess/tools/TAuxManager.h
• Control/xAODRootAccess/xAODRootAccess/tools/TObjectManager.h
• Control/xAODRootAccess/xAODRootAccess/tools/TPrimitiveAuxBranchManager.h
• Control/xAODRootAccess/xAODRootAccess/tools/TVirtualManager.h

Adding @akraszna ,@ssnyder as watchers

WARNING: big files (>100K) are found in the changeset

140K in file Control/xAODRootAccess/Root/TEvent.cxx

Looks OK from AR viewpoint, approving

Giovanni (AR)

removed analysis-review-required label

added analysis-review-approved label

CI Result SUCCESS (hash 27449b31)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 63124]

The changes look fine and there are no CI issues. Approving.

Jason (L1)

added review-approved label and removed review-pending-level-1 label

added review-approved-point1 label

added review-approved-tier0 label

merged

mentioned in commit a2b26ad5

added sweep:ignore label