introduce a first version of options for configuration blocks
The basic idea/goal of configuration blocks is that the configuration system can read a configuration text file and then configure the blocks accordingly. This is made a lot simpler if the configurable options on the blocks can be set via a uniform interface.
This is just a first draft of such a mechanism that allows to add the options and set them by name from the python side. All I want from this MR is a basic interface that allows to add the options on the individual blocks and set them through a python interface. That will then allow me to update all the configuration blocks to expose options before I move on.
The mechanism for setting option values is even more rudimentary, doing just the minimal thing to allow setting the properties through a standard interface. This is mostly there to allow me to move forward somehow, but some details may change. The interface I have right now is probably not ideal for anybody, neither for the text nor the python configuration. That probably needs some changing at some point.
There is a much more sophisticated prototype available, but because of its complexity I didn't want to incorporate it into this first draft. Instead the interface I have should be (mostly) compatible with the interface that prototype exposes. It can then be retrofitted in here at some point. The full prototype is here: https://gitlab.cern.ch/jburr/configblock/-/tree/master/
Also: For photons the recomputeIsEM option should probably not be repeated in both the calibration and selection blocks. There needs to be a special method for forwarding options from one block to the next which will come in a future update, or when the full option mechanism gets incorporated here.
Merge request reports
Activity
added alsoTargeting:21.2 label
added Analysis Egamma analysis-review-required master review-pending-level-1 labels
CI Result FAILURE (hash cb6cd0cf)Athena AnalysisBase AthAnalysis externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 1, warnings 16
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 63090]I got some feedback from @jburr to look at his prototype here: https://gitlab.cern.ch/jburr/configblock/-/tree/master/
I will see if I can incorporate that, and until then marking this as Draft.
CI Result SUCCESS (hash cb6cd0cf)Athena AnalysisBase AthAnalysis externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 63125]added 44 commits
-
cb6cd0cf...115629ba - 43 commits from branch
atlas:master
- 80b7702b - introduce a first version of options for configuration blocks
-
cb6cd0cf...115629ba - 43 commits from branch
CI Result SUCCESS (hash 80b7702b)Athena AnalysisBase AthAnalysis externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 63149]added review-pending-level-2 label and removed review-pending-level-1 label
- Resolved by Karolos Potamianos
added review-approved label and removed review-pending-level-2 label
- Resolved by Nils Erik Krumnack
- Resolved by Jon Burr
- Resolved by Nils Erik Krumnack
added 1 commit
- c8f0d0ed - introduce a first version of options for configuration blocks
added review-pending-level-1 label and removed review-approved label
CI Result SUCCESS (hash c8f0d0ed)Athena AnalysisBase AthAnalysis externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 63222]added review-approved label and removed review-pending-level-1 label
added review-approved-point1 label
added analysis-review-approved label and removed analysis-review-required label
mentioned in merge request !59093 (merged)
mentioned in merge request !59099 (merged)
mentioned in commit 558493d9
added sweep:done label
added sweep:failed label
mentioned in merge request !60046 (closed)
removed alsoTargeting:21.2 label
removed sweep:failed label