Skip to content
Snippets Groups Projects

introduce a first draft of a factory for analysis configuration blocks

Merged Nils Erik Krumnack requested to merge krumnack/athena:config_factory into master

This file defines a factory method that can create a configuration block sequence based on a passed in name. This avoids having to import all the various config block sequence makers in the configuration code, and also would make it easier to create them from a text configuration file.

This relies heavily on the blocks exposing all configurable parameters as options, since there is no other mechanism to configure them through this interface.

The implementation itself is probably not the best possible, it lacks all extensibility, gathers all information in a single place, etc. Still for now this ought to be good enough.

Marking this as draft until !59013 (merged) gets merged, as this is designed on top of that.

Edited by Nils Erik Krumnack

Merge request reports

Pipeline #4870815 passed

Pipeline passed for 5381e98b on krumnack:config_factory

Approval is optional

Merged by Walter LamplWalter Lampl 2 years ago (Dec 13, 2022 11:50am UTC)

Merge details

  • Changes merged into master with 844924af.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading