Assume Pythia83 for the master
Merge request reports
Activity
This merge request affects 1 package:
- Generators/Pythia8_i
This merge request affects 5 files:
- Generators/Pythia8_i/CMakeLists.txt
- Generators/Pythia8_i/Pythia8_i/Pythia8_i.h
- Generators/Pythia8_i/Pythia8_i/UserHooksFactory.h
- Generators/Pythia8_i/cmake/FindHepMC3Pythia8Interface.cmake
- Generators/Pythia8_i/src/Pythia8_i.cxx
added Generators master review-pending-level-1 labels
- Resolved by Andrii Verbytskyi
CI Result SUCCESS (hash c7713fb0)Athena AthGeneration externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 63326]removed review-pending-level-1 label
added review-pending-expert label
@averbyts you've tagged several people, without any specific question, what feedback are you expecting, and from whom ? David as L2
Sorry for the delay... Yes, this looks fine. If we don't need to use that special/weird header out of HepMC3 anymore, then let's just remove the
FindHepMC3PythiaInterface.cmake
module. As I wrote in !59108 (merged), that setup was anyway not as robust as I would've liked it.added review-approved label and removed review-pending-expert label
- Resolved by Andrii Verbytskyi
mentioned in commit 2673f14d
added sweep:ignore label