Skip to content
Snippets Groups Projects

Assume Pythia83 for the master

Merged Andrii Verbytskyi requested to merge averbyts/athena:drop_old_pythia82 into master
All threads resolved!

Assume Pythia83 for the master

Tag @ewelina @akraszna @jchapman @cgutscho

Edited by Andrii Verbytskyi

Merge request reports

Pipeline #4873480 passed

Pipeline passed for c7713fb0 on averbyts:drop_old_pythia82

Approval is optional

Merged by Walter LamplWalter Lampl 2 years ago (Dec 16, 2022 3:06pm UTC)

Merge details

  • Changes merged into master with 2673f14d.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • :pencil: :scissors: The system determined that CI tests (with names matching "^CITest_Trigger.*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

  • :white_check_mark: CI Result SUCCESS (hash c7713fb0)

    Athena AthGeneration
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 63326]

  • Andrii Verbytskyi changed the description

    changed the description

  • Andrii Verbytskyi resolved all threads

    resolved all threads

  • @averbyts you've tagged several people, without any specific question, what feedback are you expecting, and from whom ? David as L2

  • Hi @droussea ,

    we just discussed this MR with Ewelina, John and Attila. Christian was tagged as Pythia8 expert. I had a question for Attila, but I think the MR is OK even as is.

    Andrii

  • Sorry for the delay... Yes, this looks fine. If we don't need to use that special/weird header out of HepMC3 anymore, then let's just remove the FindHepMC3PythiaInterface.cmake module. As I wrote in !59108 (merged), that setup was anyway not as robust as I would've liked it.

  • Andrii Verbytskyi resolved all threads

    resolved all threads

  • Dear @averbyts, all

    everything looks fine from my side. Please go ahead, and let's monitor the next AthGeneration behavior keeping this change in mind.

    Giancarlo

  • Walter Lampl mentioned in commit 2673f14d

    mentioned in commit 2673f14d

  • merged

  • Please register or sign in to reply
    Loading