Share common code between MuonStationBuilder and MuonStationBuilderCond

This follows MR!59277

Same idea

• We create an Impl clas.
• We move all the common things to it .
• Note that is NOT new code but copy paste of the "common" code
• So it has the same "issues", but now in one place not two (so potentially easer to solve in the future?)
• The 2 derived ones differ on how one "gets" the EventContext
• So we end up with a single 1500 lines impl, rather than 2 ...

This follows some discussion with @jchapman.

PS: I will need to migrate in a similar mannes another piece of code before...

But prb we will need to change the interface of Trk::IDetachedTrackingVolumeBuilder to Trk::IDetachedTrackingVolumeBuilderCond i.e to return unique_ptr. As here it leads to having to "release" things so as to conform to the existing interface.

This is prb 2 MRs down the road but will be needed before "the final step".

added full-integration-tests full-unit-tests labels

There were multiple CI triggers for this MR and commit. The system ignored duplicates but the GitLab pipeline status may incorrectly show the job as failed. Once the remaining job finished running, the CI results will be posted as usual.

This merge request affects 1 package:

• MuonSpectrometer/MuonDetDescr/MuonTrackingGeometry

This merge request affects 6 files:

• MuonSpectrometer/MuonDetDescr/MuonTrackingGeometry/MuonTrackingGeometry/MuonStationBuilder.h
• MuonSpectrometer/MuonDetDescr/MuonTrackingGeometry/MuonTrackingGeometry/MuonStationBuilderCond.h
• MuonSpectrometer/MuonDetDescr/MuonTrackingGeometry/MuonTrackingGeometry/MuonStationBuilderImpl.h
• MuonSpectrometer/MuonDetDescr/MuonTrackingGeometry/src/MuonStationBuilder.cxx
• MuonSpectrometer/MuonDetDescr/MuonTrackingGeometry/src/MuonStationBuilderCond.cxx
• MuonSpectrometer/MuonDetDescr/MuonTrackingGeometry/src/MuonStationBuilderImpl.cxx

Adding @rosati ,@wleight ,@stavrop ,@amorley ,@jojungge ,@apsallid ,@pscholer as watchers

added MuonSpectrometer master review-pending-level-1 labels

changed the description

CI Result SUCCESS (hash ef7e8f00)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 63627]

Jenkins please retry a build

This merge request affects 1 package:

• MuonSpectrometer/MuonDetDescr/MuonTrackingGeometry

This merge request affects 6 files:

• MuonSpectrometer/MuonDetDescr/MuonTrackingGeometry/MuonTrackingGeometry/MuonStationBuilder.h
• MuonSpectrometer/MuonDetDescr/MuonTrackingGeometry/MuonTrackingGeometry/MuonStationBuilderCond.h
• MuonSpectrometer/MuonDetDescr/MuonTrackingGeometry/MuonTrackingGeometry/MuonStationBuilderImpl.h
• MuonSpectrometer/MuonDetDescr/MuonTrackingGeometry/src/MuonStationBuilder.cxx
• MuonSpectrometer/MuonDetDescr/MuonTrackingGeometry/src/MuonStationBuilderCond.cxx
• MuonSpectrometer/MuonDetDescr/MuonTrackingGeometry/src/MuonStationBuilderImpl.cxx

Adding @rosati ,@wleight ,@stavrop ,@amorley ,@jojungge ,@apsallid ,@pscholer as watchers

CI Result SUCCESS (hash ef7e8f00)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 63629]

very minor comments from my side -- L1

added review-user-action-required label and removed review-pending-level-1 label

resolved all threads

removed review-user-action-required label

added review-pending-level-1 label

Looks good. Apporved

Sergei L1

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 7ab6bc28

added sweep:ignore label