Skip to content
Snippets Groups Projects

Add CA configuration for DESDM_MCP & DRAW_ZMUMU

Merged Johannes Junggeburth requested to merge jojungge/athena:ATLASRECTS-7423 into master
All threads resolved!
  • Add CA configuration for the DESDM_MCP & DRAW_ZMUMU file formats (Tagging: @pscholer, @rosati, @cgrefe, @gfacini)
  • Transform the MuonAnalysisThinningTool to an reentrant algorithm
  • AsgSelectionToolWrapper declares the data dependencies
  • Add various CA snippets to DerivationFrameworkTools

Tagging: @jcatmore, @tadej Closes ATLASRECTS-7423

Edited by Johannes Junggeburth

Merge request reports

Checking pipeline status.

Approval is optional

Merged by Adam Edward BartonAdam Edward Barton 2 years ago (Jan 24, 2023 9:27am UTC)

Merge details

  • Changes merged into master with 6d19c8da (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Tadej Novak resolved all threads

    resolved all threads

  • :pencil: Build area was cleaned as per request posted in the DB. The full software build will be performed

  • This merge request affects 4 packages:

    • PhysicsAnalysis/DerivationFramework/DerivationFrameworkMuons
    • PhysicsAnalysis/DerivationFramework/DerivationFrameworkTools
    • PhysicsAnalysis/PrimaryDPDMaker
    • Reconstruction/RecJobTransforms

    Affected files list will not be printed in this case

    Adding @apsallid ,@jcatmore ,@maklein ,@mvanadia ,@gabarone ,@calpigia ,@goetz as watchers

  • :pencil: Build area was cleaned as per request posted in the DB. The full software build will be performed

  • This merge request affects 4 packages:

    • PhysicsAnalysis/DerivationFramework/DerivationFrameworkMuons
    • PhysicsAnalysis/DerivationFramework/DerivationFrameworkTools
    • PhysicsAnalysis/PrimaryDPDMaker
    • Reconstruction/RecJobTransforms

    Affected files list will not be printed in this case

    Adding @apsallid ,@jcatmore ,@maklein ,@mvanadia ,@gabarone ,@calpigia ,@goetz as watchers

  • :x: CI Result FAILURE (hash df540f7c)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :o:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 64900]

  • :x: CI Result FAILURE (hash a67abaa1)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :o:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 64902]

  • added 1 commit

    • 1b951d79 - Wondering why this doesn't work

    Compare with previous version

  • This merge request affects 4 packages:

    • PhysicsAnalysis/DerivationFramework/DerivationFrameworkMuons
    • PhysicsAnalysis/DerivationFramework/DerivationFrameworkTools
    • PhysicsAnalysis/PrimaryDPDMaker
    • Reconstruction/RecJobTransforms

    Affected files list will not be printed in this case

    Adding @apsallid ,@jcatmore ,@maklein ,@mvanadia ,@gabarone ,@calpigia ,@goetz as watchers

  • :white_check_mark: CI Result SUCCESS (hash 1b951d79)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 64922]

  • The changes look fine and there are no CI issues. Approving.

    Jason (L1)

  • mentioned in commit 6d19c8da

  • Please register or sign in to reply
    Loading