Fix nsw calib alg

This MR fixes a bug in the handling of the detId in the NswCalibDbAlg that prevented the code from reading the pdo calibration constants correctly.

@cheidegg @sangelid can you please have a look if this fix is doing the correct thing?

For the review: The first commit is just some code formatting while the second commit contains the actual changes

cc @iodice @rosati @lucam

Build area was cleaned as per request posted in the DB. The full software build will be performed

This merge request affects 1 package:

• MuonSpectrometer/MuonConditions/MuonCondGeneral/MuonCondAlg

This merge request affects 1 file:

• MuonSpectrometer/MuonConditions/MuonCondGeneral/MuonCondAlg/src/NswCalibDbAlg.cxx

Adding @apsallid ,@rosati ,@wleight ,@pscholer ,@stavrop ,@jojungge as watchers

added MuonSpectrometer master review-pending-level-1 labels

Hi @sangelid after this fix is applied I am able to read the pdo calibration constants but get many warnings about invalid identifiers. All invalid identifiers have in common that uint16_t channelNumber = helper.channel_number(); returns a channel number of 0 (it is new line 319, sorry gitlab does not let me comment on that line directly). Is channelNumber 0 a default value that indicates s.th. went wrong or a regular channel number?

CI Result FAILURE (hash cc084704)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 64679]

Hi @pscholer the CI fails due to a crash (Unhandled 'std::exception' exception has been thrown) in CITest_DerivationRun2Data_PHYS-test

Can you take a look at what is going on?

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• cf762b4e - change WARNING about bad identifiers to DEBUG

Compare with previous version

This merge request affects 1 package:

• MuonSpectrometer/MuonConditions/MuonCondGeneral/MuonCondAlg

This merge request affects 1 file:

• MuonSpectrometer/MuonConditions/MuonCondGeneral/MuonCondAlg/src/NswCalibDbAlg.cxx

Adding @apsallid ,@rosati ,@wleight ,@pscholer ,@stavrop ,@jojungge as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result SUCCESS (hash cf762b4e)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 64728]

marked this merge request as draft

removed review-pending-level-1 label

added 2 commits

• e184fc52 - more warning to debug
• 129f895d - only protect against strips with negative charges, keep pads and wires

Compare with previous version

resolved all threads

marked this merge request as ready

This merge request affects 2 packages:

• MuonSpectrometer/MuonCnv/MuonSTGC_CnvTools
• MuonSpectrometer/MuonConditions/MuonCondGeneral/MuonCondAlg

Affected files list will not be printed in this case

Adding @rosati ,@wleight ,@stavrop ,@jojungge ,@apsallid ,@pscholer as watchers

added review-pending-level-1 label

CI Result SUCCESS (hash 129f895d)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 64751]

added bugfix label

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• f10125d0 - remove return after throw

Compare with previous version

This merge request affects 2 packages:

• MuonSpectrometer/MuonCnv/MuonSTGC_CnvTools
• MuonSpectrometer/MuonConditions/MuonCondGeneral/MuonCondAlg

Affected files list will not be printed in this case

Adding @rosati ,@wleight ,@stavrop ,@jojungge ,@apsallid ,@pscholer as watchers

added review-pending-level-1 label and removed review-user-action-required label

resolved all threads

CI Result FAILURE (hash f10125d0)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 64788]

resolved all threads

added 1 commit

• 6768cf9b - fix typos in comments

Compare with previous version

Build area was cleaned as per request posted in the DB. The full software build will be performed

This merge request affects 2 packages:

• MuonSpectrometer/MuonCnv/MuonSTGC_CnvTools
• MuonSpectrometer/MuonConditions/MuonCondGeneral/MuonCondAlg

Affected files list will not be printed in this case

Adding @rosati ,@wleight ,@stavrop ,@jojungge ,@apsallid ,@pscholer as watchers

CI Result FAILURE (hash 6768cf9b)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 64799]

added review-approved label and removed review-pending-level-1 label

resolved all threads

added review-approved-tier0 label

Jenkins please retry a build

This merge request affects 2 packages:

• MuonSpectrometer/MuonCnv/MuonSTGC_CnvTools
• MuonSpectrometer/MuonConditions/MuonCondGeneral/MuonCondAlg

Affected files list will not be printed in this case

Adding @rosati ,@wleight ,@stavrop ,@jojungge ,@apsallid ,@pscholer as watchers

added review-pending-level-1 label and removed review-approved review-approved-tier0 labels

removed review-pending-level-1 label

added review-approved review-approved-tier0 labels

CI Result SUCCESS (hash 6768cf9b)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 64844]

merged

mentioned in commit e9aed518

added sweep:ignore label