Move (almost all) components out of CaloUtils
The package Calorimter/CaloUtils grew over the years into a somewhat messy grab-bag of helpers and athena-components (Algs,Tools). So it has to be "dual-use" library. This MR moves almost all the components to other places that feel more appropriate to me (CaloRec
, CaloClusterCorrection
). With this change, the size of the build shrinks by about 5 MBytes.
There are two components remaining: CaloTowerStoreTestAlg
and CaloUtils::ToolWithConstantsTestTool
. As the name suggests, their purpose is to test helper classes in CaloUtils. Not so obvious where to move them. Technicall, the CaloTowerStoreTestAlg
could be move easily to CaloRec. The ToolWithConstantTestTool
is more tricky, because it is used from a python algo, so it needs python bindings (and is a component).
If I remove these two tests and do not build a component-library for CaloUtils at all, the disk-saving is 12Mbytes.
I would like to hear @ssnyder's thoughts on this issue ...