Skip to content
Snippets Groups Projects

change handling of JVT in CP algorithms (ATLASG-2447)

Merged Nils Erik Krumnack requested to merge krumnack/athena:atlasg_2447 into master
All threads resolved!

There was a difference between sequence and block configuration in the nightlies, which caused the test failures in the nightlies. I changed a number of minor things about the jvt configuration:

  • add SuppressInputDependence flag to JetVertexTaggerTool
  • disable runJvtUpdate for the test sequence
  • don't include the JVT selection in the global jet selection, but introduce a selection named JVT.

The last is indeed what fixed the discrepancy, though I'm unsure if this is the right thing to do, or if instead I ought to have a baseline for all jets that includes JVT. I leave that for the jet experts.

Also reordered configuration blocks to match configuration sequences. This is mostly meant to allow easier comparisons of the generated sequence to spot differences more easily.

Edited by Nils Erik Krumnack

Merge request reports

Pipeline #5045009 passed

Pipeline passed for 7a2a69b4 on krumnack:atlasg_2447

Approval is optional

Merged by Adam Edward BartonAdam Edward Barton 2 years ago (Jan 25, 2023 5:11pm UTC)

Merge details

  • Changes merged into master with c0012012.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 8 commits

    • 2dab36bd...d65af973 - 4 commits from branch atlas:master
    • e94df681 - reorder configuration blocks to match configuration sequences
    • 2d622415 - add SuppressInputDependence flag to JetVertexTaggerTool
    • f35ee036 - set runJvtUpdate to False for the test sequence
    • 7a2a69b4 - move JVT selection into its own selection flag (solves ATLASG-2447)

    Compare with previous version

  • This merge request affects 2 packages:

    • PhysicsAnalysis/Algorithms/AnalysisAlgorithmsConfig
    • PhysicsAnalysis/Algorithms/JetAnalysisAlgorithms

    Affected files list will not be printed in this case

    Adding @krumnack ,@tadej ,@pagessin as watchers

  • Nils Erik Krumnack changed title from add SuppressInputDependence flag to JetVertexTaggerTool (ATLASG-2447) to change handling of JVT in CP algorithms (ATLASG-2447)

    changed title from add SuppressInputDependence flag to JetVertexTaggerTool (ATLASG-2447) to change handling of JVT in CP algorithms (ATLASG-2447)

  • Nils Erik Krumnack changed the description

    changed the description

  • :x: CI Result FAILURE (hash 2dab36bd)

    Athena AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark:
    tests :o: :white_check_mark: :o:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 65036]

  • :white_check_mark: CI Result SUCCESS (hash 7a2a69b4)

    Athena AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 65045]

  • Nils Erik Krumnack resolved all threads

    resolved all threads

  • Approving as CP algs expert.

  • mentioned in commit c0012012

  • Sweep summary
    failed:

    • 21.2
  • Nils Erik Krumnack mentioned in merge request !60046 (closed)

    mentioned in merge request !60046 (closed)

  • Please register or sign in to reply
    Loading